Skip to content

Leave the day's compose page as evidence - #2068

Merged
stefan-burke merged 2 commits into
mainfrom
claude/evidence-one-days-audience
Aug 10, 2026
Merged

Leave the day's compose page as evidence#2068
stefan-burke merged 2 commits into
mainfrom
claude/evidence-one-days-audience

Conversation

@stefan-burke

@stefan-burke stefan-burke commented Aug 10, 2026

Copy link
Copy Markdown
Member

Current-system value

The marketing site illustrates its pages with screenshots taken from these stories, so a page's picture is a real page a real case reached rather than a mock-up. The Perfect For pages have none of these yet; this adds the first one, for the online events page.

What it does

One declaration and one line of spec support:

  • scripts/specs/evidence/declarations.ts declares one-days-audience, taken from writing.one-day-hears-and-the-others-do-not (merged in Aim a bulk email at one day of a listing booked by the day #2067).
  • opensEmailForListingDay calls leaveEvidencePage with the compose URL it already built, so the story hands over the address it reached rather than anything constructing one.

No production code changes. The capture is of /admin/emails?listing=…&day=…, which names the listing and the one day the message is aimed at, and counts who that day reaches — the claim the site's online events page makes.

Why this case

The page tells organisers a term booked date by date can be addressed a date at a time. This case is that sentence: Rachel books day 1, Marco books day 8, the message goes to day 1, and only Rachel hears. The screenshot is the moment before sending, showing "Attendees of the Course on Tuesday 11 August 2026" and one recipient.

What is not here

How it looks. evidence-themes/one-days-audience.css belongs to the site repository, per the split the evidence docs describe: the app decides what a capture is, the publisher decides what it looks like. The matching site change is in tickets-site#146.

Checks

  • deno task specs — 232 scenarios, 1525 steps, all pass
  • deno task specs:evidence --themes <site>/evidence-themes — 25 scenarios, 171 steps, all pass; artifact validated and imported by the site
  • deno task lint — clean
  • deno task typecheck — the 5 pre-existing errors in scripts/ and uptime-kuma/socket.ts, unchanged

Generated by Claude Code

Summary by CodeRabbit

  • Tests
    • Expanded mobile evidence coverage for branded email composition screens.
    • Added verification points for day-based and attendee-based message workflows.
    • Improved consistency of captured evidence across related compose pages.

The marketing site illustrates its pages with screenshots taken from these
stories. The day-target case now leaves behind the compose page it opened,
which names the listing and the one day the message is aimed at — the claim
the online events page makes.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UU8geYkKNGrFu5ArzfxSC6
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 42 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8fde0810-b2e6-4ca5-acbb-077c7a1d7dd6

📥 Commits

Reviewing files that changed from the base of the PR and between a6d36c6 and 6963aec.

📒 Files selected for processing (1)
  • test/specs/support/bulk-email.ts
📝 Walkthrough

Walkthrough

The change adds the one-days-audience mobile evidence capture and records evidence at day-specific and listing-wide bulk-email compose pages.

Changes

One-day audience evidence

Layer / File(s) Summary
Evidence capture declaration
scripts/specs/evidence/declarations.ts
Adds the one-days-audience branded mobile capture for .page-regions.admin-page.
Compose page evidence recording
test/specs/support/bulk-email.ts
Imports leaveEvidencePage and records evidence after opening both compose page types.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: preserving the day's compose page as evidence.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/evidence-one-days-audience
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch claude/evidence-one-days-audience

Comment @coderabbitai help to get the list of available commands.

The evidence call landed in the whole-listing way in as well as the day's,
carrying a comment about a day that way in never picks. jscpd caught it as a
clone, but the duplicate was the bug: a scenario using both would have left
the listing-wide compose page as the day's evidence.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UU8geYkKNGrFu5ArzfxSC6
@stefan-burke
stefan-burke added this pull request to the merge queue Aug 10, 2026
Merged via the queue into main with commit 381179b Aug 10, 2026
3 checks passed
@stefan-burke
stefan-burke deleted the claude/evidence-one-days-audience branch August 10, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants