Test volunteer sign-ups and payment choices as user journeys

[stefan-burke]

What changed

• describe a free volunteer sign-up as a user journey, including an access request, confirmation details, and the organiser attendee view
• describe switching back to saved Stripe test settings as a user journey through the real settings form
• publish the tested mobile payment settings view as screenshot evidence for the website
• replace the old broad booking test with these smaller stories while keeping encrypted attendee backup restoration as a focused technical contract
• share the admin form browser helper and check every theme value used by branded evidence

Why

These journeys now document the rules in plain language and still exercise the real rendered forms. The screenshot used by the website comes from the same payment-provider story.

Verification

• nix develop -c deno task test:files test/scripts/specs/evidence-style.test.ts
• nix develop -c deno task precommit
• nix develop -c deno task test:screenshot-contract
• nix develop -c deno task specs:evidence

[coderabbitai]

📝 Walkthrough

Walkthrough

Changes

Payment provider coverage

Layer / File(s)	Summary
Payment settings evidence capture scripts/specs/evidence/declarations.ts, test/scripts/specs/evidence-style.test.ts	Centralizes branded theme CSS, adds payment-provider settings styling, registers a mobile evidence capture, and validates inherited CSS across branded captures.
Saved Stripe provider scenario specs/payments/payment-provider-choice.feature, test/specs/steps/payment-provider-choice.ts, test/scripts/specs/catalog.test.ts	Adds coverage for switching from Square to a saved Stripe test setup and verifying the resulting settings UI and provider messaging.

Volunteer sign-up coverage

Layer / File(s)	Summary
Volunteer sign-up scenario specs/bookings/volunteer-sign-up.feature, specs/owners.json, test/specs/steps/volunteer-sign-up.ts	Adds free shift sign-up coverage, including an accessibility request, confirmation details, and organiser attendee visibility.
Scenario browser and world state test/specs/support/browser.ts, test/specs/support/world.ts	Adds reusable scenario/admin browser helpers and stores group and question identifiers in the Cucumber world.

Test infrastructure updates

Layer / File(s)	Summary
Shared admin form submission test/specs/steps/servicing-hold.ts, test/specs/support/browser.ts	Moves servicing-hold admin submissions to the shared authenticated form helper.
Backup attendee restoration validation test/shared/db/backup/restore.test.ts	Verifies encrypted attendee details remain decryptable after backup restoration.
Browser API cleanup test/test-utils/test-browser.ts	Removes the unused checkbox-value getter; the previous end-to-end booking flow test file is also deleted.

Estimated code review effort: 4 (Complex) | ~45 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Scenario
  participant AdminSettings
  participant PaymentState
  Scenario->>AdminSettings: Submit Stripe provider selection
  AdminSettings->>PaymentState: Preserve saved Stripe test key
  PaymentState-->>AdminSettings: Render Stripe selected and test-mode notice
  AdminSettings-->>Scenario: Verify provider labels and saved key

Loading

sequenceDiagram
  participant Volunteer
  participant SignUp
  participant AttendeeRecords
  participant Organiser
  Volunteer->>SignUp: Submit free shift and access request
  SignUp->>AttendeeRecords: Record booking and access note
  Organiser->>AttendeeRecords: Open shift attendees
  AttendeeRecords-->>Organiser: Show volunteer details and access note

Loading

Possibly related PRs

• chobbledotcom/tickets#1921: Refactors servicing-hold steps to use the shared admin form helper.
• chobbledotcom/tickets#1924: Updates the evidence capture declarations and branded CSS pipeline.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: moving volunteer sign-ups and payment choices into user journey tests.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feature/more-cucumber-stories

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch feature/more-cucumber-stories

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@test/scripts/specs/evidence-style.test.ts`:
- Around line 50-60: Update the variable-name list in the evidence-style
completeness test to include --color-accent, --color-secondary, and
--color-shadow, ensuring every variable generated by brandedThemeCss and used by
the payment CSS is asserted.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b1408266-6bd7-4711-90ba-08b441d5516d

📥 Commits

Reviewing files that changed from the base of the PR and between b3bf68f and 7cc1d93.

📒 Files selected for processing (14)

• scripts/specs/evidence/declarations.ts
• specs/bookings/volunteer-sign-up.feature
• specs/owners.json
• specs/payments/payment-provider-choice.feature
• test/e2e/booking.test.ts
• test/scripts/specs/catalog.test.ts
• test/scripts/specs/evidence-style.test.ts
• test/shared/db/backup/restore.test.ts
• test/specs/steps/payment-provider-choice.ts
• test/specs/steps/servicing-hold.ts
• test/specs/steps/volunteer-sign-up.ts
• test/specs/support/browser.ts
• test/specs/support/world.ts
• test/test-utils/test-browser.ts

💤 Files with no reviewable changes (2)

• test/e2e/booking.test.ts
• test/test-utils/test-browser.ts