Record folded-booking line 381 dayCount equivalent - #1916
Conversation
The base.dayCount:1 mutant is provably equivalent: childDaysFromParent uses dayCount only in the customisable_days branch, which processParentApiBooking rejects before reaching the fold. All 63 mutants now killed or suppressed.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 43 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. 📝 WalkthroughWalkthroughMutation tracking documentation now records the folded-booking mutant at line 381:17 as equivalent and updates the TODO entry to state that all mutants are covered, with five known equivalents. ChangesMutation coverage records
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@TODO.md`:
- Around line 1402-1405: Update the TODO entry describing the folded-booking
mutation tests to distinguish test-killed mutants from the five suppressed
equivalent mutants, stating that the tests kill every non-equivalent mutant
while preserving the existing proof and survivor details.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: f349f8d7-3b87-4819-808e-cdf83c296c1f
📒 Files selected for processing (2)
TODO.mdscripts/mutation/equivalent-mutants.txt
What changed
Records the last mutation equivalent for
src/features/api/folded-booking.tsinscripts/mutation/equivalent-mutants.txt, bringing the mutation score to 100% (58 killed, 5 suppressed, 0 survivors).Why
PR #1913 was merged before this final commit landed. The line 381 mutant (
dayCount: 1 → 0in theFoldBase) is provably equivalent:childDaysFromParentusesdayCountonly in thecustomisable_daysbranch, whichprocessParentApiBookingrejects before reaching the fold. For daily parents the function returnsclampDurationDays(parent.duration_days), and for standard parents it returns1(thestandardValue) — neither readsdayCount, so1and0produce the same output for every reachable input.Without this recording on main, the next
precommit:mutationrun on afolded-booking.tschange would report line 381 as a survivor.Checks
nix develop -c deno task mutation:audit-equivalents— all 438 equivalents valid.nix develop -c deno task mutationonfolded-booking.ts— 100% (58/58 killed, 5 suppressed).nix develop -c deno task precommit— green.Summary by CodeRabbit