Make admin routes their own source of truth

[stefan-burke]

What changed

• Define each admin method and path beside the handler that serves it.
• Remove the second 43-file route catalog and the ID-to-route adapter.
• Keep navigation destinations and the small read-only allowlist focused on their own jobs.
• Remove an unused settings toggle component that had no production caller.

This keeps lazy loading, typed route parameters, route priority, permissions, and read-only behavior unchanged. It also means a route and its handler can no longer drift between two separate declarations.

Result

• Source AST nodes: 511,410 to 507,661
• Reduction: 3,749 nodes (0.73%)
• Source files: 1,123 to 1,078
• Repository diff: 1,672 fewer lines

Checks

• deno task precommit
• 221 focused route, read-only, and UI tests
• Read-only mutation test: 39 of 39 mutants detected
• Edge build and 0% duplication checks

Summary by CodeRabbit

• New Features

  • Updated admin route handling across the administrative area for more consistent access to existing pages and actions.
  • Expanded read-only mode to permit selected safe administrative operations, including login/logout, support, delivery updates, scans, and diagnostic actions.

• Bug Fixes

  • Improved consistency between read-only access rules and available administrative operations.

• Refactor

  • Consolidated admin route definitions without changing the functionality of existing pages, forms, or actions.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 80a8fdab-9fc5-44f9-974b-9046c3a792ad

📥 Commits

Reviewing files that changed from the base of the PR and between d487b37 and bf24e63.

📒 Files selected for processing (101)

• src/features/admin/api-keys.ts
• src/features/admin/area-loaders.ts
• src/features/admin/attendee-notes.ts
• src/features/admin/attendee-refunds.ts
• src/features/admin/attendees.ts
• src/features/admin/attributes.ts
• src/features/admin/auth.ts
• src/features/admin/backup.ts
• src/features/admin/builder.ts
• src/features/admin/built-sites.ts
• src/features/admin/bulk-actions.ts
• src/features/admin/bulk-email.ts
• src/features/admin/calendar.ts
• src/features/admin/catalog-transfer/routes.ts
• src/features/admin/contact-history.ts
• src/features/admin/dashboard.ts
• src/features/admin/debug.ts
• src/features/admin/deliveries.ts
• src/features/admin/groups.ts
• src/features/admin/guide.ts
• src/features/admin/handlers.ts
• src/features/admin/holidays.ts
• src/features/admin/images.ts
• src/features/admin/index.ts
• src/features/admin/ledger.ts
• src/features/admin/listing-qr.ts
• src/features/admin/listings.ts
• src/features/admin/markdown-preview.ts
• src/features/admin/modifiers.ts
• src/features/admin/news.ts
• src/features/admin/privacy.ts
• src/features/admin/questions.ts
• src/features/admin/scanner.ts
• src/features/admin/seeds.ts
• src/features/admin/servicing.tsx
• src/features/admin/sessions.ts
• src/features/admin/settings-logistics.ts
• src/features/admin/settings-statuses.ts
• src/features/admin/settings.ts
• src/features/admin/site-pages.ts
• src/features/admin/site.ts
• src/features/admin/sms.ts
• src/features/admin/support.ts
• src/features/admin/update.ts
• src/features/admin/users.ts
• src/features/app/read-only.ts
• src/shared/admin-surface.ts
• src/shared/admin-surface/definitions.ts
• src/shared/admin-surface/routes/api-keys.ts
• src/shared/admin-surface/routes/attendee-notes.ts
• src/shared/admin-surface/routes/attendee-refunds.ts
• src/shared/admin-surface/routes/attendees.ts
• src/shared/admin-surface/routes/attributes.ts
• src/shared/admin-surface/routes/auth.ts
• src/shared/admin-surface/routes/backup.ts
• src/shared/admin-surface/routes/builder.ts
• src/shared/admin-surface/routes/built-sites.ts
• src/shared/admin-surface/routes/bulk-actions.ts
• src/shared/admin-surface/routes/bulk-email.ts
• src/shared/admin-surface/routes/calendar.ts
• src/shared/admin-surface/routes/catalog-transfer.ts
• src/shared/admin-surface/routes/contact-history.ts
• src/shared/admin-surface/routes/dashboard.ts
• src/shared/admin-surface/routes/debug.ts
• src/shared/admin-surface/routes/deliveries.ts
• src/shared/admin-surface/routes/groups.ts
• src/shared/admin-surface/routes/guide.ts
• src/shared/admin-surface/routes/holidays.ts
• src/shared/admin-surface/routes/images.ts
• src/shared/admin-surface/routes/index.ts
• src/shared/admin-surface/routes/ledger.ts
• src/shared/admin-surface/routes/listing-qr.ts
• src/shared/admin-surface/routes/listings.ts
• src/shared/admin-surface/routes/markdown-preview.ts
• src/shared/admin-surface/routes/modifiers.ts
• src/shared/admin-surface/routes/news.ts
• src/shared/admin-surface/routes/privacy.ts
• src/shared/admin-surface/routes/questions.ts
• src/shared/admin-surface/routes/scanner.ts
• src/shared/admin-surface/routes/seeds.ts
• src/shared/admin-surface/routes/servicing.ts
• src/shared/admin-surface/routes/sessions.ts
• src/shared/admin-surface/routes/settings-logistics.ts
• src/shared/admin-surface/routes/settings-statuses.ts
• src/shared/admin-surface/routes/settings.ts
• src/shared/admin-surface/routes/site-pages.ts
• src/shared/admin-surface/routes/site.ts
• src/shared/admin-surface/routes/sms.ts
• src/shared/admin-surface/routes/support.ts
• src/shared/admin-surface/routes/update.ts
• src/shared/admin-surface/routes/users.ts
• src/ui/templates/admin/attributes.tsx
• src/ui/templates/admin/questions.tsx
• src/ui/templates/admin/settings/boolean-settings-section.tsx
• test/features/app/read-only.test.ts
• test/integration/routes/read-only.test.ts
• test/lib/admin-route-manifest.test.ts
• test/shared/admin-surface.test.ts
• test/shared/admin-surface/definitions.test.ts
• test/shared/admin-surface/routes/built-sites.test.ts
• test/ui/templates/admin/settings/boolean-settings-section.test.tsx

💤 Files with no reviewable changes (49)

• src/shared/admin-surface/routes/ledger.ts
• src/shared/admin-surface/routes/attendees.ts
• src/shared/admin-surface/routes/listing-qr.ts
• src/shared/admin-surface/routes/questions.ts
• src/shared/admin-surface/routes/debug.ts
• src/shared/admin-surface/routes/update.ts
• test/shared/admin-surface/definitions.test.ts
• src/shared/admin-surface/routes/site.ts
• src/shared/admin-surface/routes/attendee-refunds.ts
• src/shared/admin-surface/routes/support.ts
• src/shared/admin-surface/routes/site-pages.ts
• src/shared/admin-surface/routes/bulk-email.ts
• src/shared/admin-surface/routes/built-sites.ts
• src/shared/admin-surface/routes/catalog-transfer.ts
• src/shared/admin-surface/routes/calendar.ts
• src/shared/admin-surface/routes/scanner.ts
• src/shared/admin-surface/routes/modifiers.ts
• src/shared/admin-surface/routes/settings.ts
• src/shared/admin-surface/routes/seeds.ts
• src/shared/admin-surface/routes/servicing.ts
• test/ui/templates/admin/settings/boolean-settings-section.test.tsx
• src/shared/admin-surface/routes/listings.ts
• src/shared/admin-surface/routes/settings-statuses.ts
• src/shared/admin-surface/routes/api-keys.ts
• src/shared/admin-surface/routes/dashboard.ts
• src/shared/admin-surface/routes/backup.ts
• src/features/admin/handlers.ts
• src/shared/admin-surface/routes/privacy.ts
• src/shared/admin-surface/routes/settings-logistics.ts
• src/shared/admin-surface/routes/deliveries.ts
• src/shared/admin-surface/routes/sms.ts
• src/shared/admin-surface/routes/users.ts
• src/shared/admin-surface/routes/auth.ts
• src/shared/admin-surface/routes/holidays.ts
• src/shared/admin-surface/routes/index.ts
• src/shared/admin-surface/routes/news.ts
• src/shared/admin-surface/routes/attributes.ts
• src/shared/admin-surface/routes/groups.ts
• src/shared/admin-surface/routes/bulk-actions.ts
• src/shared/admin-surface/routes/contact-history.ts
• src/ui/templates/admin/settings/boolean-settings-section.tsx
• src/shared/admin-surface/routes/builder.ts
• src/shared/admin-surface/routes/sessions.ts
• src/shared/admin-surface/routes/guide.ts
• src/shared/admin-surface/routes/attendee-notes.ts
• src/shared/admin-surface/routes/markdown-preview.ts
• test/shared/admin-surface.test.ts
• src/shared/admin-surface/routes/images.ts
• src/shared/admin-surface/definitions.ts

---

📝 Walkthrough

Walkthrough

Changes

The admin routing system now uses explicit METHOD /path maps via defineRoutes, loaded lazily per admin area. Legacy route-ID definitions, handlers, and manifest aggregation were removed. Read-only checks, admin path generation, reorder links, and related tests now use route patterns and area manifests.

Admin routing migration

Layer / File(s)	Summary
Explicit admin route maps src/features/admin/*.ts, src/features/admin/catalog-transfer/routes.ts	Admin handlers are registered with defineRoutes using concrete HTTP methods and paths while preserving existing handler functions.
Route manifest and surface contracts src/features/admin/index.ts, src/features/admin/area-loaders.ts, src/shared/admin-surface.ts, src/shared/admin-surface/definitions.ts, src/shared/admin-surface/routes/*	Lazy area loaders now provide route maps directly; legacy route helpers, route metadata, and aggregated admin route exports are removed.
Read-only and generated paths src/features/app/read-only.ts, src/ui/templates/admin/attributes.tsx, src/ui/templates/admin/questions.tsx	Read-only admin operations use fixed path patterns, and reorder actions construct explicit URLs instead of route-ID mappings.
Validation updates test/features/app/read-only.test.ts, test/integration/routes/read-only.test.ts, test/lib/admin-route-manifest.test.ts, test/shared/admin-surface*.test.ts	Tests validate loaded area routes, method/path uniqueness, destination coverage, and the revised read-only allowlist.

Estimated code review effort: 4 (Complex) | ~45 minutes

Possibly related PRs

• chobbledotcom/tickets#1717: Changes related admin segment-based lazy route loading and manifest validation.
• chobbledotcom/tickets#1847: Modifies the same read-only request-guard behavior.
• chobbledotcom/tickets#1850: Updates overlapping admin feature route wiring.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately captures the main change: admin routes now define themselves as the source of truth instead of relying on a separate catalog.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch reduce-admin-route-ast

---

_{Comment @coderabbitai help to get the list of available commands.}