Repository navigation
Migrate timezone/date utilities to Temporal (bundled polyfill) #1321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9026d8b
Replace @internationalized/date with the built-in Temporal API
claude b880f8e
Reject offset/zone-bearing datetimes in localToUtc and isValidDatetime
claude 8ba59c1
Keep todayInTz controllable under FakeTime via Date.now()
claude 13eece6
Bundle Temporal via temporal-polyfill instead of the runtime global
claude 4ce3466
Reject :60 leap seconds in the naive datetime guard
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When date-dependent code is exercised under
@std/testing/time'sFakeTime, this now reads the real wall clock becauseFakeTimeoverridesDate/timers whileTemporal.Nowuses the runtime clock directly. The previous@internationalized/datetoday()path was backed byDate.now(), so fake-time tests for booking windows, holiday cutoffs, or delivery/calendar pages can now calculate “today” from the actual date instead of the frozen date; derive the Temporal instant fromDate.now()before converting to the requested timezone to keep this helper controllable.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed and fixed in 8ba59c1. Verified empirically: under
FakeTimefrozen at 2030-01-15,Temporal.Now.plainDateISOreturned the real date while aDate.now()-derived instant returned the frozen one.todayInTznow derives "today" fromDate.now()(via a sharedmsToZonedhelper thatutcToZonedalso uses), restoring the freezable behaviour the oldtoday()had. Added aFakeTimetest that locks it in.server-qr-book/renewals(FakeTime + todayInTz) still pass via the harness.Generated by Claude Code