Refactor/#3 jdbc template 학습테스트 실패환경 구성 #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boorownie
requested changes
Nov 24, 2023
Contributor
boorownie
left a comment
boorownie
left a comment
There was a problem hiding this comment.
비어있는 코드 잘 반영해주셨습니다 👍
코멘트 남겼으니 확인 부탁해요!
Comment on lines
30
to
31
| List<Object[]> splitUpNames = Arrays.asList("John Woo", "Jeff Dean", "Josh Bloch", "Josh Long") | ||
| .stream() |
Contributor
Author
There was a problem hiding this comment.
아 별다른 이유는 없고, 무의식적으로 한 줄에 점 하나 쓰는 습관이 있어서 바꾼 것 같습니다.
into Feature/cho-log#3-jdbcTemplate_학습테스트_실패환경_구성
- findCustomerByFirstName
hong-sile
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 작업 내용
LMS의 ✅ 학습 테스트 - jdbcTemplaAPI 페이지를 기준으로 실패하는 테스트 환경을 구성했습니다.
추가적으로 테스트 하나가 빠져있더라고요.
QueryigDao의
findCustomersByFirstName에 해당하는 테스트 추가했습니다.
💬 리뷰 중점사항
디스코드에서 제시한 의견처럼 환경을 구성하시는 건 어떤가요?
close #3