-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup and performance improvements #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ok, I've also fixed compatibility with Julia v0.5, v0.6, and nightly on Linux. Appveyor is broken with Julia nightly due to JuliaLang/julia#20899 |
This looks cool! Thanks for PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better version of #19
This does the following:
user_f
anduser_j
withconst Ref
s, usingFunctionWrapper
s to ensure type-stabilitysparse_matrix
code, because Julia's built-inSparseMatrixCSC
does the same thingsolveMCP
methods which exist only to provide default arguments, because default argument values already create those extra methods automatically.I did some profiling with the following benchmark:
Before this PR, I saw about 2.67 ms, and after this PR I see 2.18 ms, or about a 20% improvement in total time. That time includes all the time spent in PATH and computing jacobians, so the actual improvement in callback overhead should be better than 20%.