Skip to content

Commit

Permalink
Bug fix in noproj to remove persistent temporary lbl file (DOI-USGS#5578
Browse files Browse the repository at this point in the history
)

* Added line to close match cube in noproj.cpp. Not closing the cube resulted in a temporary "*.lbl" file that remained after running the noproj application. Addresses DOI-USGS#5577.

* CHANGELOG entry for noproj bug fix. Addresses DOI-USGS#5577.

* Added history entry in noproj.xml. Addresses DOI-USGS#5577.
  • Loading branch information
chkim-usgs committed Nov 25, 2024
1 parent f056bce commit 06aa3d7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
3 changes: 2 additions & 1 deletion isis/src/base/apps/noproj/noproj.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,8 @@ namespace Isis {
Cube matchCube;
matchCube.open(matchCubeFile.expanded(), "rw");
cam2cam(icube, &matchCube, cam2camUI);

matchCube.close();

// Cleanup by deleting the match files
QStringList detfiles = findAllDetachedFiles( label );
detfiles.append(matchLbl);
Expand Down
4 changes: 4 additions & 0 deletions isis/src/base/apps/noproj/noproj.xml
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,10 @@
<change name="Ken Edmundson" date="2024-01-09">
Incorporated Kris Becker's 2021-09-22 bug fix above into USGS code base.
</change>
<change name="Ken Edmundson" date="2024-08-07">
Additional bug fix to address persistent temporary lbl file after
running noproj. Fixes #5577.
</change>
</history>

<category>
Expand Down

0 comments on commit 06aa3d7

Please sign in to comment.