worker: have terminate return a promise.

See: nodejs/node#28021
chjj · Jun 11, 2019 · 29dc3fd · 29dc3fd
1 parent 2a9c61e
commit 29dc3fd
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/lib/browser/worker.js b/lib/browser/worker.js
@@ -262,14 +262,19 @@ class Worker extends EventEmitter {
     });
   }
 
-  terminate(callback) {
+  async terminate(callback) {
     if (this._exited)
       return;
 
     if (typeof callback === 'function')
       this.once('exit', code => callback(null, code));
 
     this._terminate(1);
+
+    // See: https://github.com/nodejs/node/pull/28021
+    return new Promise((resolve) => {
+      this.once('exit', resolve);
+    });
   }
 
   unref() {

diff --git a/lib/process/worker.js b/lib/process/worker.js
@@ -638,14 +638,19 @@ class Worker extends EventEmitter {
     this._exited = true;
   }
 
-  terminate(callback) {
+  async terminate(callback) {
     if (this._exited)
       return;
 
     if (typeof callback === 'function')
       this.once('exit', code => callback(null, code));
 
     this._terminate(1);
+
+    // See: https://github.com/nodejs/node/pull/28021
+    return new Promise((resolve) => {
+      this.once('exit', resolve);
+    });
   }
 
   unref() {