Skip to content

Add CI job for tree-sitter-systemverilog#6076

Merged
tgorochowik merged 1 commit intochipsalliance:masterfrom
gmlarumbe:tree-sitter-systemverilog-2
Sep 17, 2024
Merged

Add CI job for tree-sitter-systemverilog#6076
tgorochowik merged 1 commit intochipsalliance:masterfrom
gmlarumbe:tree-sitter-systemverilog-2

Conversation

@gmlarumbe
Copy link
Contributor

The parser is missing in the public report since I forgot to add a CI job for it.

I simply added an entry in the RUNNERS_TARGETS var of the runners.mk file. Not sure if something else is needed. I also added it to the list of supported tools in the README.md

Let me know if something else is needed.

Thanks!

@tgorochowik
Copy link
Member

Thanks!
To make it actually run, it needs to be added in the CI configuration (github actions in this case)

Please look here for reference: https://github.com/chipsalliance/sv-tests/blob/master/.github/workflows/sv-tests-ci.yml#L16

@gmlarumbe gmlarumbe force-pushed the tree-sitter-systemverilog-2 branch from edb2601 to 6186dce Compare September 16, 2024 16:56
@gmlarumbe
Copy link
Contributor Author

Thanks a lot for the reference.

I added a new entry for tree-sitter-systemverilog with gcc as a dependency for compilation of the parser into a shared object. Not sure if it is needed or if it is already available in the system running CI.

I was also wondering if libtree-sitter-dev would be needed but I noticed that tree-sitter is being downloaded via pip through the conf/requirements.txt file. Could it be ugraded to a more recent version of tree sitter? Current is 0.20.4 and latest is 0.23.0

Thanks!

@tgorochowik
Copy link
Member

I think it was set to an older version because something was failing to build, feel free to bump it to a newer release, if the CI is still green after the upgrade, we can merge it

@tgorochowik
Copy link
Member

You can bump it here or in a separate PR if you prefer

@tgorochowik tgorochowik merged commit 52af777 into chipsalliance:master Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants