-
Notifications
You must be signed in to change notification settings - Fork 642
[svsim] Add -j, --build-jobs, and --verilate-jobs #5051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
seldridge
merged 9 commits into
main
from
dev/seldridge/svsim-expose-verilator-compile-time-parallelism-options
Oct 10, 2025
Merged
[svsim] Add -j, --build-jobs, and --verilate-jobs #5051
seldridge
merged 9 commits into
main
from
dev/seldridge/svsim-expose-verilator-compile-time-parallelism-options
Oct 10, 2025
+289
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Verilator compilation-time options to the Verilator svsim backend. This is added to workaround an issue observed internally where Verilator can crash when running with full parallelism, i.e., the default `-j 0` that was previously hard-coded in the Verilator backend. The default behavior is preserved, but users can now set `-j` OR `--build-jobs`/`--verilate-jobs` individually. Signed-off-by: Schuyler Eldridge <[email protected]>
4992a93
to
24ee0e1
Compare
seldridge
commented
Oct 9, 2025
jackkoenig
approved these changes
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, see comments, consider making new CompilationSettings constructor private
jackkoenig
reviewed
Oct 9, 2025
77d26fa
to
6decefd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Verilator compilation-time options to the Verilator svsim backend.
This is added to workaround an issue observed internally where Verilator
can crash when running with full parallelism, i.e., the default
-j 0
that was previously hard-coded in the Verilator backend.
The default behavior is preserved, but users can now set
-j
OR--build-jobs
/--verilate-jobs
individually.Release Notes
Add control of Verilator build parallelism to svsim.