[fuse_ctrl, integration] Fix fuse_ctrl background checks init error #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reinstates the background checks in the fuse_ctrl provisioning smoke tests by fixing the order of registers write to enable the periodic integrity and consistency checks. The CHECK_TIMEOUT register needs to be written before INTEGRITY_CHECK_PERIOD and CONSISTENCY_CHECK_PERIOD or an unintended timeout error is triggered. Signed-off-by: Andrea Caforio <[email protected]>
In the fuse_ctrl an integrity/consistency check is triggered as soon as either the `INTEGRITY_CHECK_PERIOD` or `CONSISTENCY_CHECK_PERIOD` registers are written. The following check, depending on the number of instantiated partitions, may last for hundreds of cycles. Writing a value into the `CHECK_TIMEOUT` register while the checks are still ongoing will trigger an unnecessary timeout error that transfers the fuse_ctlr into an error state. This commit adjusts the documentation to make it clear that the `CHECK_TIMEOUT` register should be written before `INTEGRITY_CHECK_PERIOD` and `CONSISTENCY_CHECK_PERIOD`. Following the Programmer's Guide verbatim before may lead to implementations that trigger this unintended error condition. Signed-off-by: Andrea Caforio <[email protected]>
ekarabu
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reinstates the background checks in the fuse_ctrl provisioning smoke tests by fixing the order of registers write to enable the periodic integrity and consistency checks.
The CHECK_TIMEOUT register needs to be written before INTEGRITY_CHECK_PERIOD and CONSISTENCY_CHECK_PERIOD or an unintended timeout error is triggered.
Related OpenTitan PR: lowRISC/opentitan#26188