-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CaliptraIntegrationSpecification.md #349
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varuns-nvidia
previously approved these changes
Dec 11, 2023
steph-morton
previously approved these changes
Dec 11, 2023
calebofearth
previously approved these changes
Dec 11, 2023
Clarifying backend convergence statement in integration requirements
e91e8ae
calebofearth
approved these changes
Dec 11, 2023
steph-morton
previously approved these changes
Dec 11, 2023
calebofearth
requested changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a request for description of brkpoint/GO usage.
Adding bootfsm brkpoint information
steph-morton
previously approved these changes
Dec 12, 2023
calebofearth
previously approved these changes
Dec 12, 2023
Removing hyphens for consistency
2a77eee
steph-morton
approved these changes
Dec 12, 2023
varuns-nvidia
approved these changes
Dec 12, 2023
Failing test timed out waiting for runner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed references to TSMC 5nm process. Closes #348
Clarified reset rules section to reference cold boot flow to be easier to find for integrators. Closes #334
Removed TODO from lint rules section. Closes #338