Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove read IDCODE instruction from VeeR JTAG TAP #298

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

mkurc-ant
Copy link
Contributor

This PR removes support for read IDCODE instruction from the TAP. This addresses #289 where Caliptra is to be connected to a system JTAG as a submodule.

@tmichalak
Copy link
Contributor

@bharatpillilli should we target a different branch ?

@bharatpillilli
Copy link
Collaborator

@mcockrell-google - SInce we did a tagged release already, is it OK to push this to the main branch and then we do another tagged RTL release?

@mcockrell-google
Copy link
Contributor

@mcockrell-google - SInce we did a tagged release already, is it OK to push this to the main branch and then we do another tagged RTL release?

Yes - that's probably the best way.

@calebofearth
Copy link
Collaborator

I currently have a sync in progress to address #284 - if we push this to dev-public, I'll grab it in dev-integrate and get it into main.

@tmichalak
Copy link
Contributor

@calebofearth I see that #299 depends on this PR. To get green CI we need #302 to go in first. Could you take a look?

@calebofearth
Copy link
Collaborator

@calebofearth I see that #299 depends on this PR. To get green CI we need #302 to go in first. Could you take a look?

I see that PR's been merged since making this request, but it looks like a simple and good change.

Internal-Tag: [#51306]
Signed-off-by: Maciej Kurc <[email protected]>
@tmichalak
Copy link
Contributor

I see that PR's been merged since making this request, but it looks like a simple and good change.

@calebofearth Okay, great. Rebased this PR on the latest dev-public.

@calebofearth
Copy link
Collaborator

Is this PR ready to go? @tmichalak or @mkurc-ant , are one of you planning to merge it?

@kgugala
Copy link
Member

kgugala commented Nov 21, 2023

@calebofearth we're waiting for some review and ACK (or comments if there is sth to address). If you're OK with the code changes here we can merge it

@calebofearth
Copy link
Collaborator

@calebofearth we're waiting for some review and ACK (or comments if there is sth to address). If you're OK with the code changes here we can merge it

Ok, thanks. Looks good to me.

@kgugala kgugala merged commit 7589fe4 into chipsalliance:dev-public Nov 21, 2023
@kgugala kgugala deleted the mkurc/remove-idcode branch November 21, 2023 21:09
@Nitsirks Nitsirks mentioned this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants