-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove read IDCODE instruction from VeeR JTAG TAP #298
Remove read IDCODE instruction from VeeR JTAG TAP #298
Conversation
@bharatpillilli should we target a different branch ? |
@mcockrell-google - SInce we did a tagged release already, is it OK to push this to the main branch and then we do another tagged RTL release? |
Yes - that's probably the best way. |
I currently have a sync in progress to address #284 - if we push this to dev-public, I'll grab it in dev-integrate and get it into main. |
@calebofearth I see that #299 depends on this PR. To get green CI we need #302 to go in first. Could you take a look? |
I see that PR's been merged since making this request, but it looks like a simple and good change. |
Internal-Tag: [#51306] Signed-off-by: Maciej Kurc <[email protected]>
Internal-Tag: [#51306] Signed-off-by: Maciej Kurc <[email protected]>
705aa85
to
cf4903d
Compare
@calebofearth Okay, great. Rebased this PR on the latest dev-public. |
Is this PR ready to go? @tmichalak or @mkurc-ant , are one of you planning to merge it? |
@calebofearth we're waiting for some review and ACK (or comments if there is sth to address). If you're OK with the code changes here we can merge it |
Ok, thanks. Looks good to me. |
This PR removes support for read IDCODE instruction from the TAP. This addresses #289 where Caliptra is to be connected to a system JTAG as a submodule.