Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document TRNG REQ HW API timing requirements #136

Closed
korran opened this issue Jun 26, 2023 · 2 comments
Closed

Document TRNG REQ HW API timing requirements #136

korran opened this issue Jun 26, 2023 · 2 comments
Assignees
Labels
1.0 spec final docs documentation Improvements or additions to documentation question Further information is requested

Comments

@korran
Copy link
Contributor

korran commented Jun 26, 2023

In Caliptra_Integration_Specification.pdf, section 8 (TRNG REQ HW API) doesn't mention timing requirements at all. These need to be documented explicitly.

We need to know the upper bound on how long this operation can take in order to set watchdog timeouts correctly.

@korran korran added the question Further information is requested label Jun 26, 2023
@andreslagarcavilla andreslagarcavilla added documentation Improvements or additions to documentation 1.0 spec final docs labels Nov 8, 2023
@FerralCoder
Copy link
Collaborator

@korran, is this still relevant based on current watchdog handling?

@FerralCoder
Copy link
Collaborator

Kor Nielsen (Google)
[7 minutes ago]
Now that the watchdog is configured externally this isn't as important.
However, we probably need to document the hard coded timeout for etrng requests. Constant is here: https://github.com/chipsalliance/caliptra-sw/blob/df44c09aab24fc72010cce83507cbab1c9e04928/drivers/src/trng_ext.rs#L18

    const MAX_CYCLES_TO_WAIT: u32 = 250000;

andreslagarcavilla added a commit to andreslagarcavilla/caliptra-rtl that referenced this issue Dec 19, 2023
andreslagarcavilla added a commit to andreslagarcavilla/caliptra-rtl that referenced this issue Dec 19, 2023
andreslagarcavilla added a commit that referenced this issue Dec 20, 2023
* Specify TRNG timing requirement

* Address #136

* Applied editorial feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 spec final docs documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants