Convert app to Electron app #101
Conversation
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
Check the status or cancel PullRequest code review here.
There was a problem hiding this comment.
Looks good to me. The new dependencies appear to be safe of any major issues and are relatively well-maintained. Lots of cool stuff you can do with Electron.
I have a small suggestion to make the createWindow method more flexible by accepting the width and height values.
Reviewed with ❤️ by PullRequest
|
|
||
| let mainWindow; | ||
|
|
||
| function createWindow() { |
There was a problem hiding this comment.
Should you consider passing width and height in the createWindow method and set them with default value of 800 and 600 respectively. This way, you will be able to passing any width or height dynamically. If the user of this method doesn't pass anything in, the width will be set to the default values.
function createWindow(width = 800, height = 600) {
mainWindow = new BrowserWindow({ width, height });
...
}
[](#74364198-945d-4af6-8e4b-d90e97c0ad26 "PullRequest Meta [Do Not Modify]")
 **Kingsten B**
norbertdragan
force-pushed
the
electron
branch
from
011a4ab to
b156be7
Compare
There was a problem hiding this comment.
⚠️ Warning
PullRequest detected a force-push on this branch. This may have caused some information to be lost, and additional time may be required to complete review of the code. Read More
This PR sets up Electron so that the game can be ran as a desktop app. The MacOS build has been tested to work properly, I am waiting on feedback from other team members whether the Linux and Windows versions work properly. I will only complete the merge once those are verified.