upstream updates to chips-core from @barrystyle #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa051d3 doc: Remove unused section from release process (MarcoFalke) Pull request description: The section does not apply to us, because it is being done by the maintainers of the `bitcoin.org` website, see bitcoin-dot-org/Bitcoin.org#3641 (comment) . Documentation about the process is in their repo: https://github.com/bitcoin-dot-org/bitcoin.org/blob/master/docs/adding-events-release-notes-and-alerts.md#release-notes ACKs for top commit: jarolrod: ACK fa051d3 Zero-1729: ACK fa051d3 fanquake: ACK fa051d3 Tree-SHA512: eadc192958bb0d1009ad94c2ec79087b87514e3d19e2e6d759440392fa4abc432c512ba60692018e789c822a98a515a5f9a42966de4f8fe6b0a8b99470a76b5c
correct some porting errors (serverchecker.cpp became sigcache.cpp)
|
To start with I'm doing functional testing on mainnet and testnet, will post my findings here. |
Fix broken calc_MoM command
Fix broken height_MoM RPC
Rebranding of help text, port change
- Removes need for user to manually call 'chips-cli settxfee x'
Fix fatal crash on 'getchaintips' call
Set an abritrary default txfee
- Error occuring because there is no conversion function for size_t to C string in pushKV variatns - When conversion from size_t to uint64_t doesn't happen automatically on some systems, error is encountered - Affects at least M1 macOS
Fix 'pushKV ambiguous' error in compilation
- Things have changed quite a bit within scripts, particularly since the addition of Taproot - Handling for CScriptIDs is somewhat different now too, so this should be checked for validity and proper function
Add komodo_(dis)connect_block() function calls
Add definitions for ImportAddress, uncomment in kmd_validation015.h
- New upgrade added code that changed the manner in which genesis block was being constructed. For ease of review, this commit patches in the old mechanics
Set flat txfee of 10k sats
Use CHIPS legacy code for creating genesis block
standardize genesis creation
increase op_return relay size
Fix validateaddress RPC, move into 'wallet' category
Use KMD-style addresses on testnet, for easier testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are all the updates fetched from @barrystyle's repo https://github.com/barrystyle/chips for upgrading chips-core to latest bitcoin-core 0.21+ (since master branch has more updates than version 0.21 branch) version.
The relevant github issue for these updates is here: chips-blockchain/chips#10
I have tested these updates by compiling and it syncs to the network as expected.
@who-biz @phm87 need your help reviewing this code, before merging to develop branch.