Repository navigation
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
Closed in favor of the upstream PR: Twigpine#1375 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Twigpine#1373.
Why
The existing breaker stops auto-compact after 3 consecutive failures to avoid retry storms. In a long-running query loop, that state can suppress future automatic compaction while history continues to grow. This keeps the retry-storm protection but makes the breaker recoverable.
Behavior
Out of scope
state.messagescap because arbitrary message slicing can corrupttool_use/tool_resultpairing and compact-boundary semantics.Testing
bun install --frozen-lockfilebun install --cwd web --frozen-lockfilepython -m pip install -r python/requirements.txtbun run smokebun test src/services/compact/autoCompact.test.tsbun test src/query/*.test.tsbun test src/services/compact/python -m pytest -q python/testsbun run security:pr-scan -- --base upstream/mainbun run test:providernpm run test:provider-recommendationbun run --cwd web typecheck && bun run --cwd web buildbun run buildgit diff --checkLocal full-suite note:
bun test --max-concurrency=1was run under a sanitized CI-like environment. Result: 2951 passed, 1 unrelated existing failure insrc/utils/conversationRecovery.hooks.test.ts(deserializeMessagesWithInterruptDetection strips thinking blocks only for OpenAI-compatible providers). Auto-compact tests pass in full-suite order after this PR's test isolation fix. UpstreammainPR Checks are green at7419d380; GitHub CI should rerun the workflow when this branch is opened against upstream.Notes
The breaker remains intentionally conservative. Cooldown retry is half-open rather than a full reset, so an unrecoverable compaction failure causes one retry per cooldown window rather than another burst of repeated attempts.
Upstream compare
GitHub API permissions in this environment blocked creating the cross-repo PR against
Gitlawb/openclaude. The upstream-ready compare is:Twigpine/openclaude@main...chioarub:fix/autocompact-cooldown