test(http2): improve test

[chimurai]

Summary by CodeRabbit

• Tests
  • Improved HTTP/2 proxy middleware testing with explicit configuration validation to ensure reliable HTTP/2 protocol handling across proxy scenarios, including HTTP/2-to-HTTP/1 and HTTP/2-to-HTTP/2 configurations with request multiplexing verification.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9304545b-dcd8-434c-a4a2-0d86495d8a64

📥 Commits

Reviewing files that changed from the base of the PR and between 9774cbf and f93a018.

📒 Files selected for processing (1)

• test/e2e/http2-server.spec.ts

---

📝 Walkthrough

Walkthrough

The pull request adds explicit HTTP/2 enablement to two E2E test scenarios in the http-proxy-middleware library. Both the HTTP/2-to-HTTP/1 and HTTP/2-to-HTTP/2 test suites now set http2: true in their createProxyMiddleware configuration, ensuring the proxy explicitly operates in HTTP/2 mode during those tests.

Changes

HTTP/2 E2E test configuration

Layer / File(s)	Summary
Enable HTTP/2 in proxy middleware E2E tests test/e2e/http2-server.spec.ts	Both the E2E http2 to http1 and E2E http2 to http2 test suites add http2: true to their proxy middleware configuration to explicitly enable HTTP/2 proxying. This ensures the proxy operates in HTTP/2 mode when testing HTTP/2 server scenarios.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• chimurai/http-proxy-middleware#1228: Introduced the initial HTTP/2 E2E test suite that this PR now enhances with explicit HTTP/2 configuration.

Poem

🐰 Two test suites, now bright and true,
HTTP/2 flags shine shiny new!
Explicit config, no guessing games—
Proxy's HTTP/2 nature now proclaimed!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title is vague and generic. 'improve test' does not convey the specific nature of the changes, which is explicitly enabling HTTP/2 proxying in test scenarios.	Consider a more descriptive title such as 'test(http2): enable http2 option in proxy middleware tests' to clearly indicate the specific improvement being made.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test-http2-improvement

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coveralls]

coverage: 94.656%. remained the same — test-http2-improvement into master