Fix: Tests on Windows #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 26, 2022 13:41
* Temporary files are closed before being passed to the library (and then carefully deleted) * Temporary file names is properly escaped * `file://` URLs are properly escaped by using `urllib.pathname2url()`
2 similar comments
|
Thank you USSX-Hares! |
darthbear
pushed a commit
that referenced
this pull request
Feb 12, 2023
* HOCONConverter: Make `__escape_*` methods protected instead of private. * Tests: Tests on Windows no longer fail: * Temporary files are closed before being passed to the library (and then carefully deleted) * Temporary file names is properly escaped * `file://` URLs are properly escaped by using `urllib.pathname2url()` --------- Co-authored-by: Peter Zaitcev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed API:
HOCONConverter.__escape_string() / .escape_match()methods are now protected instead of privateChanged Tests:
(and then carefully deleted)
file://URLs are properly escaped by usingurllib.pathname2url()