Implement version 0.7.5 of Glk spec #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stubs for the documentation of giblorb_load_image_info() and giblorb_image_info_t because they are not described in the Glk spec yet. The new symbols are marked as unstable in the docs.
For gidispatch_set_autorestore_registry, include a stub. The new symbols are marked as unstable in the docs because they are not mentioned in any version of the Glk specification yet.
The new glk.h header file adds __attribute__((noreturn)) to glk_exit(). However, g_thread_exit() does not have this annotation, so indicate to the compiler that the function really can never return. See https://gitlab.gnome.org/GNOME/glib/-/merge_requests/3562
The Glk specification 0.7.5 clarifies that this is supposed to return NULL silently, and not abort as some early Glk libraries did. We already returned NULL, but not silently, so it's a good opportunity to include a test.
In Glk 0.7.5, Unicode file streams written in text mode are required to be written out with UTF-8 encoding. We already did this, but add some tests exercising each of the glk_put_... functions that check that the file is written using UTF-8 encoding.
Character input in graphics windows is new in version 0.7.5 of the Glk specification. It's relatively easy to enable; add key presses to the events accepted by the graphics window's GtkDrawingArea, and allow the graphics window to have the input focus. Add a test, for which we also have to give glkunit-runner the ability to send character input to the Glk program.
New in the 0.7.5 Glk spec is a note about zero-size windows. They should disappear completely, including any borders that they have. This change makes the size allocation code ignore zero-size windows, and in the case of a pair window that is going to allocate zero size to one of its children, it should instead give the entire space to its other child, eliminating the border. This is an interesting problem to test, but it can be done by testing against a reference image. This mechanism might be useful for writing more tests in the future, so we add a reftest runner (and image diffing code copied from GTK's reftest suite.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of this is actually either copying the changes in the specification text and the platform-independent blorb/dispatch layers, or improvements to the mechanisms we have for testing. There was not that much to change inside the library: