Various Bugfixes #64
Merged
Various Bugfixes #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ptomato
commented
Oct 30, 2023
ptomato
commented
- Documentation fix
- Unit test runner improvement
- Fix for not emitting start and stop notifications when Unix startup code fails
- Fix for freeing Glk program args too early
The resource usage constants are Snd, Exec, Pict, and Data. The others are chunk type constants.
Tests probably work fine without it but it's good to have it.
We would not run glk_main() but exit the Glk thread immediately if glkunix_startup_code() returns FALSE, signifying failure. However, in this situation, neither the ::started nor ::stopped signals would be emitted. We need to emit at least ::stopped, because programs may be relying on it to know when to call gtk_main_quit(). And if we emit ::stopped, we should emit ::started before it.
Previously we would free the startup argument strings right after executing the Unix startup function in the Glk program. However, the Glk program may hold on to these strings; Glulxe does, for one. Move them to the ChimaraGlkPrivate data structure to ensure they last for the lifetime of the Glk program.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.