common/hexutil: replace customized bit sizer with bit.Uintsize#108
Closed
zhedazijingang wants to merge 1 commit intochiliz-chain:masterfrom
Closed
common/hexutil: replace customized bit sizer with bit.Uintsize#108zhedazijingang wants to merge 1 commit intochiliz-chain:masterfrom
zhedazijingang wants to merge 1 commit intochiliz-chain:masterfrom
Conversation
Signed-off-by: zhedazijingang <unwrap_or_else@outlook.com>
Author
|
friendly ping~ |
Member
|
Hey @zhedazijingang, thanks for taking an interest in Chiliz Chain and for taking the time to prepare this PR. However, I don’t think we need to merge it, since this was already added to Geth in this PR: ethereum/go-ethereum#32304, which will eventually be integrated into our codebase when we fetch changes from upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
replace customized bit sizer with bit.Uintsize
Inspired by https://github.com/ethereum/go-ethereum/pulls?q=bit.Uintsize
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: