Update to support python3 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brad-x
commented
Mar 2, 2022
| @@ -182,16 +189,17 @@ def job_to_vmx(self, job_id): | |||
|
|
|||
| def get_ip(self, vmx): | |||
| count = 1 | |||
| while count <= 36: | |||
| while count <= 5: | |||
There was a problem hiding this comment.
36 5 second round-trips through this created a lengthy startup period per-VM - if we can't get an IP from the instance within 15 seconds on a modern system we should probably bail (opinionated change admittedly)
brad-x
commented
Mar 2, 2022
| @@ -148,7 +155,7 @@ def get_running(self): | |||
| return d | |||
|
|
|||
| def start_vmx(self, vmx): | |||
| cmd = [self.vmrun, 'start', vmx] | |||
| cmd = [self.vmrun, 'start', vmx, 'nogui'] | |||
There was a problem hiding this comment.
Another opinionated change here to launch VM's in the background. Would probably be better to have this be a flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates to move away from deprecated plistlib functions