ignoreLoadingBar parameter not working on response #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I need to make multiple requests to a service (one every second) in order to get results. So I used the ignoreLoadingBar parameter for my $http requests and used the cfpLoadingBar.start() and cfpLoadingBar.complete() manually. The problem is that only the request ignores the loading bar animation. Even if I pass the ignoreLoadingBar parameter, on response my manually triggered loading bar gets hidden.
|
Great catch. I'll need to add some tests to ensure, and will merge right afterwards |
|
It seems you modified the built js, not the original src. Can you please redo this modifying the src only? |
Pushing fix to src for ignoreLoadingBar parameter to work on response and rejection.
Modified build file as it was initially
|
Done, I modified the src js file and removed my changes from the built source. |
chieffancypants
added a commit
that referenced
this pull request
Jun 9, 2014
|
This landed in 6bb2b60. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to make multiple requests to a service (one every second) in order to get results. So I used the ignoreLoadingBar parameter for my $http requests and used the cfpLoadingBar.start() and cfpLoadingBar.complete() manually.
The problem is that only the request ignores the loading bar animation. Even if I pass the ignoreLoadingBar parameter, on response my manually triggered loading bar gets hidden.