Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update loading-bar.js #131

Closed
wants to merge 1 commit into from
Closed

Update loading-bar.js #131

wants to merge 1 commit into from

Conversation

brunoporto
Copy link

response.config return: "undefined .config" on offline connection. Added "response!=undefined &&" to prevent this.

response.config return: "undefined .config" on offline connection. Added "response!=undefined &&" to prevent this.
@chieffancypants
Copy link
Owner

I'm not sure I understand this -- why would an offline connection not return a response when it's mandated by angular?

@brunoporto
Copy link
Author

if you have a web app on localhost and the server "break down".
loading-bar

@chieffancypants
Copy link
Owner

Do you have other interceptors in use?

@brunoporto
Copy link
Author

angular-growl-2 break too, same solution: JanStevens/angular-growl-2#50

@chieffancypants
Copy link
Owner

@brunoporto take a look at #50, which is likely what's happening. Another discussion at #132 where perhaps I'll fix this once and for all, but it won't be by simply ignoring the error.

Thanks for the PR, but based on #132, I'll probably end up logging the error to raise awareness.

@brunoporto
Copy link
Author

is not just ignore the error ... no response = no loading bar. responsibility for handling this error is not of this plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants