[app:components:ExternalLink] Do not automatically open external links

in new tab
chichiwang · Jul 6, 2024 · 24c29fe · 24c29fe
1 parent 7b9f2bc
commit 24c29fe
Show file tree

Hide file tree

Showing 7 changed files with 1 addition and 222 deletions.
diff --git a/app/Layout/__tests__/Nav.test.js b/app/Layout/__tests__/Nav.test.js
@@ -69,7 +69,6 @@ describe('Layout/Nav Component', () => {
       render(<RouterWrappedNav />);
 
       expect(screen.getByRole('link', { name: 'Github logo' })).toHaveAttribute('href', 'https://github.com/chichiwang/tamsui');
-      expect(screen.getByRole('link', { name: 'Github logo' })).toHaveAttribute('target', '_blank');
     });
   });
 });
diff --git a/app/Layout/__tests__/__snapshots__/Nav.test.js.snap b/app/Layout/__tests__/__snapshots__/Nav.test.js.snap
@@ -42,8 +42,6 @@ exports[`Layout/Nav Component matches snapshot 1`] = `
     >
       <a
         href="https://github.com/chichiwang/tamsui"
-        rel="noreferrer"
-        target="_blank"
       >
         <img
           alt="Github logo"

diff --git a/app/Layout/__tests__/__snapshots__/index.test.js.snap b/app/Layout/__tests__/__snapshots__/index.test.js.snap
@@ -141,8 +141,6 @@ exports[`Layout Component - default matches no-child snapshot 1`] = `
           >
             <a
               href="https://github.com/chichiwang/tamsui"
-              rel="noreferrer"
-              target="_blank"
             >
               <img
                 alt="Github logo"
@@ -181,8 +179,6 @@ exports[`Layout Component - default matches no-child snapshot 1`] = `
           Created by 
           <a
             href="https://github.com/chichiwang"
-            rel="noreferrer"
-            target="_blank"
           >
             Chi-chi Wang
           </a>

diff --git a/app/components/ExternalLink/__tests__/__snapshots__/index.test.js.snap b/app/components/ExternalLink/__tests__/__snapshots__/index.test.js.snap
@@ -4,8 +4,6 @@ exports[`ExternalLink Component className snapshot 1`] = `
 <a
   className="color-orange dotted-underline"
   href="https://developer.mozilla.org/"
-  rel="noreferrer"
-  target="_blank"
 >
   <b>
     Developer Documentation
@@ -16,8 +14,6 @@ exports[`ExternalLink Component className snapshot 1`] = `
 exports[`ExternalLink Component matches snapshot 1`] = `
 <a
   href="https://www.github.com"
-  rel="noreferrer"
-  target="_blank"
 >
   Repository
 </a>

diff --git a/app/components/ExternalLink/index.tsx b/app/components/ExternalLink/index.tsx
@@ -11,7 +11,7 @@ function ExternalLink({
   href,
 }: ExternalLinkProps) {
   return (
-    <a className={className} href={href} rel="noreferrer" target="_blank">
+    <a className={className} href={href}>
       {children}
     </a>
   );