Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Compatibility with Updated Packages and Resolve Errors in Development Setup #207

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

DebdipWritesCode
Copy link

Summary of Changes

1. Update .prettierrc Configuration for Line Endings

  • Added "endOfLine": "lf" to the .prettierrc file.
  • Ensures consistent line endings as lf, resolving errors flagged by ESLint related to incorrect line endings.

2. Fix Outdated package-lock.json

  • Deleted the existing package-lock.json file and regenerated it by running npm install.
  • No significant changes were made, but this ensures consistency with the current package versions.

3. Update to Latest Version of react-tooltip

  • Upgraded react-tooltip to its latest version due to TypeScript compatibility issues.
  • Adjusted usage syntax, replacing the ReactTooltip component with the new Tooltip component.

4. Switch to react-dnd from Deprecated react-beautiful-dnd

  • Replaced react-beautiful-dnd with react-dnd as per the official deprecation notice.
  • Ensures compatibility and alignment with actively maintained libraries.

Outstanding Issues

Type Errors with react-awesome-query-builder/ui

We are encountering errors during development when running npm start. The errors are related to type problems with react-awesome-query-builder/ui, specifically with the Builder and Query components.

Screenshots of the errors:
Error Screenshot 1
Error Screenshot 2


Steps Attempted

  1. Updated react-awesome-query-builder to the latest version

    • The issue persists even after the update.
  2. Strong Type Checking

    • Despite enforcing strict type checks, the errors remain unresolved.

Suggested Solutions

1. Upgrade to React 18

  • In a separate project using React 18.3.1, react-awesome-query-builder/ui functions correctly without type errors.
  • Migrating to React 18 might resolve the issue, but it will likely require updating other dependencies for compatibility.

2. Switch to react-querybuilder

  • This package could serve as an alternative to react-awesome-query-builder if the migration to React 18 is successful.

Personal Note

I am genuinely interested in the mission of Chicago PCDC and would love the opportunity to contribute more actively to this project. Thank you for considering this pull request! 😊

@DebdipWritesCode
Copy link
Author

Hii @grugna , may I get a review for this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant