Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jindo_runtime example #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add jindo_runtime example #1

wants to merge 1 commit into from

Conversation

yangyuliufeng
Copy link

Ⅰ. Describe what this PR does

添加了jindo_runtime示例:jindo_runtime示例的实现较为简单,会直接通过helm install完成master、worker的部署,并且把dataset从notbound改为bound。没有实现完整的生命周期,如volume的删除;也没有对dataset和jindoruntime的资源对象进行详细的修改。
对fluid进行了少量改动:需要修改csi-nodeplugin的挂载目录和挂载检查脚本;需要修改创建runtime的factory.go

Ⅱ. Does this pull request fix one issue?

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@cheyang
Copy link
Owner

cheyang commented Nov 24, 2020

能否单独提交PR,将能够通用的方法下沉,谢谢!

@codecov-io
Copy link

Codecov Report

Merging #1 (33391d3) into master (36c185b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #1   +/-   ##
=======================================
  Coverage   17.98%   17.98%           
=======================================
  Files          53       53           
  Lines        2269     2269           
=======================================
  Hits          408      408           
  Misses       1822     1822           
  Partials       39       39           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36c185b...33391d3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants