Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github-actions): avoid using the deprecated version of actions/upload-artifact #30

Conversation

hituzi-no-sippo
Copy link
Contributor

@hituzi-no-sippo hituzi-no-sippo commented Sep 18, 2024

actions/upload-artifact v2 is deprecated, so GitHub Actions will be failed as follows.

This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v2`. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

GitHub Actions Results

References

@chevdor
Copy link
Owner

chevdor commented Sep 19, 2024

Thanks for the PR, there is already a fix (103775c) for it.

@chevdor chevdor closed this Sep 19, 2024
@hituzi-no-sippo hituzi-no-sippo deleted the fix/avoid-using-the-deprecated-version-of-actions/upload-artifact branch September 19, 2024 09:26
@hituzi-no-sippo hituzi-no-sippo restored the fix/avoid-using-the-deprecated-version-of-actions/upload-artifact branch September 19, 2024 09:27
@hituzi-no-sippo hituzi-no-sippo changed the title fix(github-actions): avoid using the deprecated version of `actions/u… fix(github-actions): avoid using the deprecated version of actions/upload-artifact Sep 19, 2024
@hituzi-no-sippo
Copy link
Contributor Author

Do we only need to upgrade download-artifact?
I think we need to upgrade upload-artifact as well.

When only download-artifact is upgraded, the GitHub Action will fail because of upload-artifact.

GitHub Actions Results

@chevdor chevdor reopened this Sep 19, 2024
@chevdor chevdor merged commit 9bc1ce5 into chevdor:master Sep 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants