review comments

cherylking · Feb 21, 2024 · 3fc2661 · 3fc2661
1 parent 9866ab3
commit 3fc2661
Showing 1 changed file with 12 additions and 13 deletions.
diff --git a/src/main/groovy/io/openliberty/tools/gradle/tasks/DevTask.groovy b/src/main/groovy/io/openliberty/tools/gradle/tasks/DevTask.groovy
@@ -704,52 +704,51 @@ class DevTask extends AbstractFeatureTask {
             // liberty extension: installDir, baseDir, cacheDir, outputDir, userDir, runtime
             // libertyRuntime dependency
             // liberty->install block: type, runtimeUrl, version, useOpenLiberty
-            boolean foundChange = false
             if (newProject.liberty.installDir != oldProject.liberty.installDir) {
                 logger.debug('liberty.installDir changed')
-                foundChange = true
+                return true
             }
             if (newProject.liberty.baseDir != oldProject.liberty.baseDir) {
                 logger.debug('liberty.baseDir changed')
-                foundChange = true
+                return true
             }
             if (newProject.liberty.cacheDir != oldProject.liberty.cacheDir) {
                 logger.debug('liberty.cacheDir changed')
-                foundChange = true
+                return true
             }
             if (newProject.liberty.outputDir != oldProject.liberty.outputDir) {
                 logger.debug('liberty.outputDir changed')
-                foundChange = true
+                return true
             }
             if (newProject.liberty.userDir != oldProject.liberty.userDir) {
                 logger.debug('liberty.userDir changed')
-                foundChange = true
+                return true
             }
             if (newProject.liberty.install.type != oldProject.liberty.install.type) {
                 logger.debug('liberty.install.type changed')
-                foundChange = true
+                return true
             }
             if (newProject.liberty.install.runtimeUrl != oldProject.liberty.install.runtimeUrl) {
                 logger.debug('liberty.install.runtimeUrl changed')
-                foundChange = true
+                return true
             }
             if (newProject.liberty.install.version != oldProject.liberty.install.version) {
                 logger.debug('liberty.install.version changed')
-                foundChange = true
+                return true
             }
             if (newProject.liberty.install.useOpenLiberty != oldProject.liberty.install.useOpenLiberty) {
                 logger.debug('liberty.install.useOpenLiberty changed')
-                foundChange = true
+                return true
             }
             if (newProject.liberty.runtime != oldProject.liberty.runtime) {
                 logger.debug('liberty.runtime changed')
-                foundChange = true
+                return true
             }
             if (newProject.configurations.libertyRuntime != oldProject.configurations.libertyRuntime) {
                 logger.debug('libertyRuntime changed')
-                foundChange = true
+                return true
             }
-            return foundChange
+            return false
         }
 
         private boolean hasServerConfigBootstrapPropertiesChanged(Project newProject, Project oldProject) {