-
-
Notifications
You must be signed in to change notification settings - Fork 99
Make test_http_over_https_error compatible with Solaris
#776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Reportβ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #776 +/- ##
==========================================
- Coverage 79.36% 79.15% -0.21%
==========================================
Files 29 29
Lines 4201 4203 +2
Branches 538 539 +1
==========================================
- Hits 3334 3327 -7
- Misses 723 730 +7
- Partials 144 146 +2 |
3cb54b1 to
a55f1a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
@mtelka could you add a contrib change note, though? |
a55f1a3 to
44c60e6
Compare
Done. |
test_http_over_https_error compatible with Solaris
|
@mtelka could you rebase w/ conflict resolution? |
The test was missing Solaris support and so it was failing.
Head branch was pushed to by a user without write access
454caff to
059c338
Compare
Done |
β What kind of change does this PR introduce?
π What is the related issue number (starting with
#)I had to do this to make the
test_http_over_https_errortest passing on illumos (a Solaris fork).β What is the current behavior? (You can also link to an open issue here)
The test fails when running on illumos.
β What is the new behavior (if this is a feature change)?
The test passes.
π Other information:
π Contribution checklist:
(If you're a first-timer, check out
this guide on making great pull requests)
the changes have been approved
and description in grammatically correct, complete sentences
This change isβ