Skip to content

Conversation

bmourgues
Copy link

@bmourgues bmourgues commented Jun 20, 2025

❓ What kind of change does this PR introduce?
cheroot accepts new requests while performing ssl handshake on some connections

  • 🐞 bug fix
  • 🐣 feature
  • πŸ“‹ docs update
  • πŸ“‹ tests/coverage improvement
  • πŸ“‹ refactoring
  • πŸ’₯ other

πŸ“‹ What is the related issue number (starting with #)
#748

Resolves #748

❓ What is the current behavior? (You can also link to an open issue here)

❓ What is the new behavior (if this is a feature change)?

πŸ“‹ Other information:
pre-commit is ok, except for 2 files I did not change (_compat.py and errors.py)
base branch was main/10.0.x

πŸ“‹ Contribution checklist:

(If you're a first-timer, check out
this guide on making great pull requests)

  • I wrote descriptive pull request text above
  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after
    the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

This change is Reviewable

@webknjaz
Copy link
Member

@bmourgues hi, the process is to always send patches against main with an option to backport to older branches. Although, I wasn't really planning to keep the v10.x.x stream alive, so a backport is rather unnecessary.

@bmourgues
Copy link
Author

Hello, I made a new PR against main #750 , you can discard this one.

About code, ssl_wrap could have been directly done in get method of threadpool, but I don't know if this would be ok with pyOpenSSL
if self.server.ssl_adapter is not None and not isinstance(conn.socket, SSLSocket): ... do_wrapping

@webknjaz
Copy link
Member

Thanks. Though, you could've updated the base branch in the PR and rebased on that to keep it. I'll close this PR, so there's no confusion between the two.

P.S. Try to use code highlighting when referencing snippets.

@webknjaz webknjaz closed this Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants