Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement auto fetch metadata (issue #9) #10

Merged
merged 2 commits into from
Aug 2, 2020

Conversation

dalanicolai
Copy link
Contributor

@dalanicolai dalanicolai commented Jul 31, 2020

Implement and document issue #9 auto fetch metadata from Google and Amazon.com (currently requires Ivy).

TODO (after discussion)

  • Use different selection tool (instead of Ivy)
  • Auto refresh calibredb-serach buffer (implemented as comment, but currently does not work due to Ivy action "preview metadata" switching to metadata-preview buffer
  • rename metadata-preview buffer (currently has different name)
  • Implement more sources options (preferably customizable as adding sources it slows down the process)
  • Copy covers to book directory

I have implemented the last TODO point already. There is no option to choose between different sources for the covers (like in Calibre gui) because the calibredb wtih -c flag always downloads from the same source, no matter which plugin has been chosen to request the metadata.

@dalanicolai dalanicolai changed the title Implement auto fetch data Implement auto fetch metadata (issue #9) Jul 31, 2020
@dalanicolai dalanicolai force-pushed the develop branch 2 times, most recently from a5eb09d to 5a5f20b Compare July 31, 2020 23:16
Implement auto fetch data from Google and Amazon.com (currently requires Ivy)
Instead of the solution in PR chenyanming#8 of requiring multiple packages in
calibredb-utils.el, I have moved the single function calibredb to calibredb.el.
Besides that this fixes (recursive) autoload issues, this also fixes that that
the :config block when defered loading of calibredb with use-package is
evaluated (this is required for evilifying keybindings in the spacemacs layer).
I presumed that defining the function calibredb directly in calibredb.el does
not cause too much confusion.

Finally I made calibredb-find-counsel autoloadable for which some
packages are required from calibredb-ivy.el.
@dalanicolai
Copy link
Contributor Author

dalanicolai commented Aug 2, 2020

The last commit here replaces PR #8, because it fixes the autoloading issues there correctly (autoloading is required for the Spacemacs layer. It seems this last commit is merged within my previous PR to add auto fetch metadata functionality (I do not see how to seperate these PR's)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants