Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Polish translations #193

Closed
wants to merge 3 commits into from
Closed

Update Polish translations #193

wants to merge 3 commits into from

Conversation

Twoomatch
Copy link
Contributor

@Twoomatch Twoomatch commented Dec 9, 2022

As in #192, plus microphone strings.
Note: "mic recording" became "sound recording" here in Polish version. Translating it literally (and more correctly) would require something like "recording with microphone" ("nagrywanie mikrofonem"), which is a bit unwieldy. There is some unfortunate semantic overlap between call and sound, but I hope it will be clear enough.

I'm not sure if creating a second pull request is a good solution - maybe you would prefer rebasing the mic branch after merging #192, and then a separate PR for mic recording strings only? Let me know.

chenxiaolong and others added 2 commits December 8, 2022 18:16
This adds a new quick settings tile that starts recording from the
microphone when enabled and stops recording when disabled. It is
completely unrelated to the call recording functionality, but does not
interfere with it either.

Signed-off-by: Andrew Gunnerson <[email protected]>
As in #192, plus microphone strings.
Note: "mic recording" became "sound recording" here in Polish version. Translating it literally would require something like "recording with microphone" ("nagrywanie mikrofonem"), which is a bit unwieldy. There is some unfortunate semantic overlap between call and sound, but I hope it will be clear enough.
@chenxiaolong
Copy link
Owner

Note: "mic recording" became "sound recording" here in Polish version. Translating it literally (and more correctly) would require something like "recording with microphone" ("nagrywanie mikrofonem"), which is a bit unwieldy. There is some unfortunate semantic overlap between call and sound, but I hope it will be clear enough.

That seems completely reasonable to me.

maybe you would prefer rebasing the mic branch after merging #192, and then a separate PR for mic recording strings only?

Sounds good. I've merged #192 and rebased the mic branch.

@Twoomatch Twoomatch closed this by deleting the head repository Dec 9, 2022
Twoomatch added a commit to Twoomatch/BCR that referenced this pull request Dec 9, 2022
chenxiaolong#193 in separate PR to keep the history clean.
PatrykMis pushed a commit to PatrykMis/BAR that referenced this pull request Dec 12, 2022
chenxiaolong#193 in separate PR to keep the history clean.
chenxiaolong pushed a commit that referenced this pull request Dec 27, 2022
#193 in separate PR to keep the history clean.
chenxiaolong pushed a commit that referenced this pull request Dec 28, 2022
#193 in separate PR to keep the history clean.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants