Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to record calls by contact. #93

Closed
Dr-Ari-Gami opened this issue Jun 21, 2022 · 8 comments
Closed

Ability to record calls by contact. #93

Dr-Ari-Gami opened this issue Jun 21, 2022 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@Dr-Ari-Gami
Copy link

I know, I know, KISS. An issue I have, however, is that I don't want to record all of my calls. I really only want to record calls from unknown numbers and from a few contacts.

I already checked the non-features list, and this isn't in it.

Apologies if this isn't the right place to request a feature.

@chenxiaolong chenxiaolong self-assigned this Jun 21, 2022
@chenxiaolong chenxiaolong added the enhancement New feature or request label Jun 21, 2022
@chenxiaolong
Copy link
Owner

Hmm, I'd suggest looking into Tasker or something similar to delete unwanted recordings as a workaround.

This would be quite nontrivial to implement with BCR's current design, so I probably won't be adding this feature. On some devices, the Android API that BCR uses doesn't even provide provide the contact information until well after the recording already started.

@Dr-Ari-Gami
Copy link
Author

Thanks for the quick response!

That's unfortunate, but makes sense. My issue is that recording the calls in the background all the time kills my battery faster than I'd like.

Is it possible to add a way to start a recording mid-call? That way if needed I can start a recording, but it won't always be recording in the background?

@chenxiaolong
Copy link
Owner

Is it possible to add a way to start a recording mid-call? That way if needed I can start a recording, but it won't always be recording in the background?

I'll think about it, but this might be a bit difficult with BCR's current design as well.

If you're willing to sacrifice a bit of space with larger files, picking the WAV output format + 8000Hz sample rate might help for your use case. WAV output does not require encoding, so BCR's CPU usage should drop from ~25% to <1%. That should help quite a bit with battery drain during recording.

@lbdroid
Copy link

lbdroid commented Jun 21, 2022

Is it possible to add a way to start a recording mid-call? That way if needed I can start a recording, but it won't always be recording in the background?

This is best implemented within the dialer itself. Some dialers do have this capability, including google dialer (location dependent), and soon also GrapheneOS dialer (GrapheneOS/platform_packages_apps_Dialer#12)

@Dr-Ari-Gami
Copy link
Author

Is it possible to add a way to start a recording mid-call? That way if needed I can start a recording, but it won't always be recording in the background?

I'll think about it, but this might be a bit difficult with BCR's current design as well.

If you're willing to sacrifice a bit of space with larger files, picking the WAV output format + 8000Hz sample rate might help for your use case. WAV output does not require encoding, so BCR's CPU usage should drop from ~25% to <1%. That should help quite a bit with battery drain during recording.

Okie! Done, it uses much less cpu now. Thanks!

@Dr-Ari-Gami
Copy link
Author

What about being able to trigger a recording from tasker. Is that possible??

Thank you for entertaining my ideas so far!

@chenxiaolong
Copy link
Owner

Similar situation there too :( BCR's current design doesn't work well for accepting intents (actions from other apps, like Tasker).

@chenxiaolong
Copy link
Owner

This has been implemented in #327 and will be included in the upcoming 1.42 release.

chenxiaolong added a commit that referenced this issue May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants