Merge pull request #37 from chenxiaolong/warnings

Fix minor compiler warnings
chenxiaolong · May 27, 2022 · 3b0480f · 3b0480f
2 parents 0ba1937 + e67ea08
commit 3b0480f
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/app/build.gradle.kts b/app/build.gradle.kts
@@ -85,7 +85,7 @@ fun getVersionName(git: Git, triple: VersionTriple): String {
     }
 }
 
-val git = Git.open(File(rootDir, ".git"))
+val git = Git.open(File(rootDir, ".git"))!!
 val gitVersionTriple = describeVersion(git)
 val gitVersionCode = getVersionCode(gitVersionTriple)
 val gitVersionName = getVersionName(git, gitVersionTriple)

diff --git a/app/magisk/updates/release/changelog.txt b/app/magisk/updates/release/changelog.txt
@@ -4,6 +4,9 @@
 * README.md: Remove mention of cloud storage. Android's Storage Access Framework does not support cloud storage when opening folders (Issue: #30, PR: #31, @chenxiaolong)
 * Add full changelog text for updates from Magisk Manager (PR: #36, @chenxiaolong)
 
+Non-user-facing changes:
+* Fix minor compiler warnings (PR: #xx, @chenxiaolong)
+
 ### Version 1.3
 
 * Write audio duration to FLAC metadata after recording is complete (Issue: #19, PR: #20, @chenxiaolong)

diff --git a/app/src/main/java/com/chiller3/bcr/CodecBottomSheetFragment.kt b/app/src/main/java/com/chiller3/bcr/CodecBottomSheetFragment.kt
@@ -130,6 +130,6 @@ class CodecBottomSheetFragment : BottomSheetDialogFragment(),
     }
 
     companion object {
-        val TAG = CodecBottomSheetFragment::class.java.simpleName
+        val TAG: String = CodecBottomSheetFragment::class.java.simpleName
     }
 }
diff --git a/app/src/main/java/com/chiller3/bcr/codec/Codecs.kt b/app/src/main/java/com/chiller3/bcr/codec/Codecs.kt
@@ -5,10 +5,10 @@ import com.chiller3.bcr.Preferences
 
 object Codecs {
     val all: Array<Codec> = arrayOf(OpusCodec, AacCodec, FlacCodec)
-    val default: Codec = all.first { it.supported }
+    private val default: Codec = all.first { it.supported }
 
     /** Find output codec by name. */
-    fun getByName(name: String): Codec? = all.find { it.name == name }
+    private fun getByName(name: String): Codec? = all.find { it.name == name }
 
     /**
      * Get the saved codec from the preferences or fall back to the default.