-
Notifications
You must be signed in to change notification settings - Fork 0
Release/0.4.x #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
d47cee4
bfc77f7
bd3efbb
e61d475
24b616b
404fa03
465b9cc
abcff34
4e7c972
a5749a7
debb3bc
278ac64
9c95aee
375d1f0
5d63835
113c1d2
1ba31e9
e608d89
2856958
d335729
c04b331
a7da1cf
9545853
f3c569d
58224dc
1a80a68
ca399cb
a4630eb
7e788c9
e12d564
87a70f1
03a738c
d06acc3
af4158b
1f705d5
a1c6c5f
ebc5a40
9e1d0de
a407b46
ee19580
db42adc
72ceffc
01eacdf
904c3f2
6c9a973
19d4944
2e8e530
2923e24
2293719
e896ae5
26fe5ba
7e58a88
de03c80
f61bd47
96e2b50
8d6969f
7f79e0a
0c7a997
0fadff3
e37c4ff
a1e7783
20e5ef4
2f95c43
9ee2c20
bb825ee
78f17e0
d98f515
6bfa7df
8097851
48eee2d
53c4ecf
e70260a
d43953b
70158ca
a985264
2223d98
be68120
8084ced
7f2a108
44854a1
05359af
eeb106c
64a3b43
3e02ce8
415ca28
28a6c0c
5cbff64
211e976
9c1424b
3cb4687
fb98607
e3d05fe
4866a26
20fea41
f85ddba
4a72352
6c2cb34
26233de
cdfd03d
df65943
e75a2de
aa7f191
24abaa7
7df07a7
cb12de2
27e80af
18b49b2
e64256e
b3e1d2a
9392ad9
75e2984
96c7524
71d75d9
6413a72
3ee14af
700ebef
ec6f0b2
b2636b1
1f4e42c
2c90c3f
9b49a94
9ae1755
6ef1f62
5b82a4f
c21550a
872a4e6
a58ed9b
c97d36b
1f47e41
b03ec12
badbb96
b2f87e2
3f2350b
dcd0112
7efc270
128d569
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,47 +1,47 @@ | ||
| name: Oracle | ||
| # name: Oracle | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| paths: | ||
| - "oracle/**" | ||
| - ".github/workflows/oracle.yaml" | ||
| pull_request: | ||
| paths: | ||
| - "build/**" | ||
| - "bindings/**" | ||
| - "node/**" | ||
| - "oracle/**" | ||
| - ".github/workflows/oracle.yaml" | ||
| # on: | ||
| # push: | ||
| # branches: | ||
| # - main | ||
| # paths: | ||
| # - "oracle/**" | ||
| # - ".github/workflows/oracle.yaml" | ||
| # pull_request: | ||
| # paths: | ||
| # - "build/**" | ||
| # - "bindings/**" | ||
| # - "node/**" | ||
| # - "oracle/**" | ||
| # - ".github/workflows/oracle.yaml" | ||
|
|
||
| defaults: | ||
| run: | ||
| working-directory: "oracle" | ||
| # defaults: | ||
| # run: | ||
| # working-directory: "oracle" | ||
|
|
||
| jobs: | ||
| check: | ||
| if: github.event.pull_request.draft == false | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Install Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: 1.22.x | ||
| - name: Lint | ||
| run: | | ||
| rm -rf $HOME/.cache/golangci-lint | ||
| make lint | ||
| test: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Install Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: 1.22.x | ||
| - name: Run build | ||
| run: make build | ||
| - name: Run tests | ||
| run: make test | ||
| # jobs: | ||
| # check: | ||
| # if: github.event.pull_request.draft == false | ||
| # runs-on: ubuntu-latest | ||
| # steps: | ||
| # - uses: actions/checkout@v3 | ||
| # - name: Install Go | ||
| # uses: actions/setup-go@v5 | ||
| # with: | ||
| # go-version: 1.24.x | ||
| # - name: Lint | ||
| # run: | | ||
| # rm -rf $HOME/.cache/golangci-lint | ||
| # make lint | ||
| # test: | ||
| # runs-on: ubuntu-latest | ||
| # steps: | ||
| # - uses: actions/checkout@v3 | ||
| # - name: Install Go | ||
| # uses: actions/setup-go@v5 | ||
| # with: | ||
| # go-version: 1.24.x | ||
| # - name: Run build | ||
| # run: make build | ||
| # - name: Run tests | ||
| # run: make test |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| [submodule "go-ethereum"] | ||
| path = go-ethereum | ||
| url = https://github.com/morph-l2/go-ethereum.git | ||
| branch = main |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Build Stage | ||
| FROM ghcr.io/morph-l2/go-ubuntu-builder:go-1.24-ubuntu as builder | ||
|
|
||
| # Set working directory and copy necessary files | ||
| COPY . /morph | ||
| WORKDIR /morph/node | ||
|
|
||
| # Run build command | ||
| RUN make build | ||
|
|
||
| # Final Stage | ||
| FROM ghcr.io/morph-l2/go-ubuntu-builder:go-1.24-ubuntu | ||
|
|
||
| # Update and install dependencies, then clean up unnecessary files | ||
| RUN apt-get -qq update \ | ||
| && apt-get -qq install -y --no-install-recommends ca-certificates \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| # Copy the built binaries from the builder image to the final image | ||
| COPY --from=builder /morph/node/build/bin/tendermint /usr/local/bin/ | ||
| COPY --from=builder /morph/node/build/bin/morphnode /usr/local/bin/ | ||
|
|
||
| # Set the default command | ||
| CMD ["morphnode", "--home", "/data"] |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| ################## update dependencies #################### | ||
| ETHEREUM_SUBMODULE_COMMIT_OR_TAG := morph-v2.1.2 | ||
| ETHEREUM_TARGET_VERSION := morph-v2.1.2 | ||
| TENDERMINT_TARGET_VERSION := v0.3.3 | ||
|
|
||
| ETHEREUM_TARGET_VERSION := v1.10.14-0.20241224100051-1582a364edc0 | ||
| TENDERMINT_TARGET_VERSION := v0.3.1 | ||
|
|
||
| ETHEREUM_MODULE_NAME := github.com/morph-l2/go-ethereum | ||
| TENDERMINT_MODULE_NAME := github.com/morph-l2/tendermint | ||
|
|
@@ -30,6 +31,7 @@ update_all_mod: | |
| @$(MAKE) update_mod MODULE=ops/tools | ||
| @$(MAKE) update_mod MODULE=oracle | ||
| @$(MAKE) update_mod MODULE=tx-submitter | ||
| @$(MAKE) update_mod MODULE=token-price-oracle | ||
|
|
||
|
|
||
| update: | ||
|
|
@@ -39,7 +41,13 @@ update: | |
|
|
||
| submodules: | ||
| git submodule update --init | ||
| git submodule update --remote | ||
| @if [ -d "go-ethereum" ]; then \ | ||
| echo "Updating go-ethereum submodule to tag $(ETHEREUM_SUBMODULE_COMMIT_OR_TAG)..."; \ | ||
| cd go-ethereum && \ | ||
| git fetch --tags && \ | ||
| git checkout $(ETHEREUM_SUBMODULE_COMMIT_OR_TAG) && \ | ||
| cd ..; \ | ||
| fi | ||
| .PHONY: submodules | ||
|
|
||
| ################## bindings #################### | ||
|
|
@@ -58,12 +66,13 @@ lint-sol: | |
| .PHONY: lint-sol | ||
|
|
||
| lint-go: | ||
| go work sync | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Clarify oracle linting being commented out. Line 67 comments out If intentional, document the reason in a code comment or PR description. If unintended, uncomment the line. Also applies to: 67-67 🤖 Prompt for AI Agents |
||
| make -C bindings lint | ||
| make -C contracts lint-go | ||
| make -C node lint | ||
| make -C ops/l2-genesis lint | ||
| make -C ops/tools lint | ||
| make -C oracle lint | ||
| ## make -C oracle lint | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Clarify why oracle linting is disabled. Line 73 comments out 🤖 Prompt for AI Agents |
||
| make -C tx-submitter lint | ||
| .PHONY: lint-go | ||
|
|
||
|
|
@@ -120,7 +129,7 @@ go-rust-alpine-builder: | |
| go-ubuntu-builder: | ||
| @if [ -z "$(shell docker images -q morph/go-ubuntu-builder 2> /dev/null)" ]; then \ | ||
| echo "Docker image morph/go-ubuntu-builder does not exist. Building..."; \ | ||
| cd ops/docker/intermediate && docker build -t morph/go-ubuntu-builder:go-1.22-ubuntu . -f go-ubuntu-builder.Dockerfile; \ | ||
| cd ops/docker/intermediate && docker build -t morph/go-ubuntu-builder:go-1.24-ubuntu . -f go-ubuntu-builder.Dockerfile; \ | ||
| else \ | ||
| echo "Docker image morph/go-ubuntu-builder already exists."; \ | ||
| fi | ||
|
|
@@ -140,7 +149,7 @@ devnet-down: | |
| cd ops/docker && docker compose -f docker-compose-4nodes.yml down | ||
| .PHONY: devnet-down | ||
|
|
||
| devnet-clean-build: devnet-down | ||
| devnet-clean-build: devnet-down devnet-l1-clean | ||
| docker volume ls --filter name=docker-* --format='{{.Name}}' | xargs -r docker volume rm | ||
| rm -rf ops/l2-genesis/.devnet | ||
| rm -rf ops/docker/.devnet | ||
|
|
@@ -156,6 +165,10 @@ devnet-clean: devnet-clean-build | |
| devnet-l1: | ||
| python3 ops/devnet-morph/main.py --polyrepo-dir=. --only-l1 | ||
|
|
||
| devnet-l1-clean: | ||
| @cd ops/docker && ./layer1/scripts/clean.sh | ||
| .PHONY: devnet-l1-clean | ||
|
|
||
| devnet-logs: | ||
| @(cd ops/docker && docker-compose logs -f) | ||
| .PHONY: devnet-logs | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: chengwenxi/morph
Length of output: 328
The
morph-v2.1.2tag does not exist in the go-ethereum submodule and will causegit checkouton line 48 to fail.The tag verification confirms that no tags matching
morph-v2are available. Without this tag, runningmake submoduleswill fail. Either ensure the tag exists in the go-ethereum submodule, point to a commit hash that exists, or use a branch reference instead of a tag.🤖 Prompt for AI Agents