Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port demos to use create react app #378

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JisuPark
Copy link

@JisuPark JisuPark commented Oct 8, 2016

Hello.

If you are okay, why don't we apply create-react-app for the demos?

We can only focus on demo code not the configurations such as react-motion/webpack.config.js
It will handle HMR or production build.

What happens if I applied CRA. (I tried to keep your files as exist.)

  • server.js and webpack.config.js files removed
  • README.md file updated
  • Each demo have their own package.json file
  • css files splitted from the HTML file (NOT NECESSARY CHANGES)

Here is related issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant