-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch the user-data on Alibaba Cloud correctly #1766
Conversation
Signed-off-by: ETiV Wang <[email protected]>
Signed-off-by: ETiV Wang <[email protected]>
Signed-off-by: ETiV Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to find docs here: https://www.alibabacloud.com/help/en/elastic-compute-service/latest/view-instance-metadata
But they don't include example output. I don't have this environment available - would you be able to include example output being parsed for user-data and other newline-delimited data in comments, or a reference to where the behavior is defined?
And, in my opinion, if the purpose of this module is to ONLY retrieve the [meta-data/...](the meta-data and its sub-directory's contents), the root URL should be If the starting point is |
Currently the meta-data API's structure is like this, I've pasted some of the file's content after
|
Thanks for the additional info @ETiV ; these changes look good. I agree that it would make more sense to include |
* No more /user-data access * No more need to access the configs through alibaba["meta_data"] Signed-off-by: ETiV Wang <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
hi @marcparadise , I just pushed a commit to apply what we've talked earlier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming tests pass, I'm 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is fine, but the tests need updating...
@ETiV - ping? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have 10 unit tests failing for this plugin specifically.
ref: chef#1766 (comment) Signed-off-by: ETiV Wang <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
@ETiV these changes look good to me, but we're still seeing test failures in the new specs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the tests around the alibaba test are failing... please fix them and we'll merge.
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your tests still need updating, please.
Kudos, SonarCloud Quality Gate passed! |
Signed-off-by: ETiV Wang <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
The response of
user-data
API should not be fetched line by line.Description
On Alibaba Cloud, the response of
user-data
metadata API is not processed properly.Related Issue
#1765
Types of changes
Checklist:
This is my first time to coding in Ruby, I've did my best 😂.
If there's any error or the coding style is not meet the repo, please just fix it, thank you.