Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verifying Ruby 3.1 compatibility on Windows #325

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

verifying Ruby 3.1 compatibility on Windows #325

wants to merge 1 commit into from

Conversation

johnmccrae
Copy link

Signed-off-by: John McCrae [email protected]

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@johnmccrae johnmccrae requested a review from a team as a code owner April 12, 2022 16:02
@johnmccrae
Copy link
Author

The problem is that chef-zero calls "pedant" from chef server. It in turn has a method called gen_rsa_key that was supposed to create the keys that are throwing the missing file errors on Windows. I just pushed a PR to Server that fixed that - chef/chef-server#3269

marcparadise
marcparadise reviewed Apr 14, 2022
View reviewed changes
.expeditor/run_windows_tests.ps1
@@ -0,0 +1,17 @@
# Stop script execution when a non-terminating error occurs
$ErrorActionPreference = "Stop"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my testing yesterday wehn this is set to 'Stop', we don't have to check $lastexitcode - the script will exit on non-zero return code.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch

marcparadise
marcparadise approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@marcparadise marcparadise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, optionally can remove the lastexitcode checks (see comment)

@sonarcloud
Copy link

sonarcloud bot commented May 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skeshari12 skeshari12 skeshari12 approved these changes

@PrajaktaPurohit PrajaktaPurohit PrajaktaPurohit approved these changes

@marcparadise marcparadise marcparadise approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnmccrae @marcparadise @PrajaktaPurohit @skeshari12