Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix waiting for ssh - ubuntu netplan dhcp-identifer format error #1550

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Fix waiting for ssh - ubuntu netplan dhcp-identifer format error #1550

merged 1 commit into from
Feb 20, 2024

Conversation

theodson
Copy link
Contributor

Fix formatting error in yaml file used by netplan ...

The problem occurs after the VM reboots and ssh connection waits (as it fails) until timeout.
Discovered this by running Netplan and reviewing the output.

netplan apply

Description

Whilst Building VMware Ubuntu 22.04 the build process would hang with waiting for ssh errors.

PACKER_LOG=1 packer build -only=vmware-iso.vm -var-file=os_pkrvars/ubuntu/ubuntu-22.04-x86_64.pkrvars.hcl -var headless=false ./packer_templates

The fix addresses the YAML formatting error.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@theodson theodson requested review from Stromweld and a team as code owners February 20, 2024 03:47
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Stromweld
Stromweld approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@Stromweld Stromweld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much that one was boggling me as to what broke.

@Stromweld Stromweld merged commit 4579204 into chef:main Feb 20, 2024
49 of 191 checks passed
@theodson
Copy link
Contributor Author

most welcome 👍 ... had me puzzled too

@theodson theodson deleted the fix-ubuntu-netplan-formatting-error branch February 21, 2024 03:16
hunleyd added a commit to hunleyd/bento that referenced this pull request Feb 29, 2024
@hunleyd
Merge branch 'main' of github.com:chef/bento
ab9f116 
* 'main' of github.com:chef/bento:
  bumped iso url versions (chef#1553)
  Fix waiting for ssh - ubuntu netplan dhcp-identifer format error (chef#1550)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stromweld Stromweld Stromweld approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@theodson @Stromweld