Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vagrant cloud cpu architecture support added #1546

Merged
merged 4 commits into from
Feb 5, 2024
Merged

vagrant cloud cpu architecture support added #1546

merged 4 commits into from
Feb 5, 2024

Conversation

Stromweld
Copy link
Collaborator

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@Stromweld Stromweld self-assigned this Feb 2, 2024
@Stromweld Stromweld marked this pull request as ready for review February 5, 2024 18:29
@Stromweld Stromweld requested review from a team as code owners February 5, 2024 18:29
@Stromweld
remove testing data
bdcf005 
Signed-off-by: Corey Hemminger <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Stromweld Stromweld merged commit 7bbfea4 into main Feb 5, 2024
63 of 191 checks passed
@Stromweld Stromweld deleted the architecture-update branch February 5, 2024 23:43
hunleyd added a commit to hunleyd/bento that referenced this pull request Feb 6, 2024
@hunleyd
Merge branch 'main' of github.com:chef/bento
e699beb 
* 'main' of github.com:chef/bento:
  vagrant cloud cpu architecture support added (chef#1546)
  Fix upload public/private flag lookup (chef#1544)
@luangong
Copy link

luangong commented Feb 12, 2024 •
edited
Loading

It would be better if the arm64 box for vmware_desktop is also in bento/ubuntu-20.04, instead of being a separate box in bento/ubuntu-20.04-arm64.

@Stromweld
Copy link
Collaborator Author

The one in bento/ubuntu-20.04-arm64 is old. I managed to get one to build on another M1 machine I have and uploaded that so there is a vmware_desktop arm64 box now in main bento/ubuntu-20.04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Stromweld Stromweld

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Stromweld @luangong