Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid downloading application to implement eject-media #1529

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Avoid downloading application to implement eject-media #1529

merged 1 commit into from
Sep 21, 2023

Conversation

MBradbury
Copy link
Contributor

Avoid downloading application to implement eject-media.ps1.

Description

eject-media.ps1 is currently implemented using EjectVolumeMedia. For Windows VMs that do not have internet access at build time they will be unable to download and execute this tool. So this change implements ejecting media (Floppy disk drives and CD drives) using pure powershell.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@MBradbury MBradbury requested review from Stromweld and a team as code owners September 20, 2023 16:31
@sonarcloud
Copy link

sonarcloud bot commented Sep 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Stromweld
Copy link
Collaborator

love it, thanks for the contribution. I'll try to get it tested in the next couple of days and then get it merged.

@Stromweld Stromweld merged commit da8c149 into chef:main Sep 21, 2023
86 of 212 checks passed
hunleyd added a commit to hunleyd/bento that referenced this pull request Nov 23, 2023
@hunleyd
Merge branch 'main' of github.com:chef/bento
f6c08aa 
* 'main' of github.com:chef/bento:
  don't try to disable system restore on servers (chef#1530)
  Avoid downloading application to implement eject-media (chef#1529)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stromweld Stromweld Awaiting requested review from Stromweld Stromweld is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MBradbury @Stromweld