Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added vagrant upload account configuration in builds.yml #1522

Merged
merged 23 commits into from
Sep 15, 2023
Merged

Conversation

Stromweld
Copy link
Collaborator

Description

added vagrant upload account configuration in builds.yml and defaulting hyperv to generation 2

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

…ng hyperv to generation 2

Signed-off-by: Corey Hemminger <[email protected]>
@Stromweld Stromweld self-assigned this Aug 14, 2023
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
…es flags, fixed upload description for libvirt to add qemu hv and version, removed debian 10, updated ubuntu 20.04 boot_command, changed workflows to be based on cpu architecture

Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
@hunleyd
Copy link

hunleyd commented Sep 12, 2023

hey @Stromweld for those of us who use this repo to manage our own 'fleet' of Vagrant images for our company.. do you have plans to expand this PR to allow us to specify the account name and if the box should be public/private? Or is this just for bento use and we should continue to use our current upload logic?

@Stromweld
Copy link
Collaborator Author

Once this is merged in the builds.yml file you can specify the account you want vagrant to upload the boxes to. it'll default to bento but if you manage your own fork then you can change it to your account. You simply need to have logged-in to the account with the vagrant cli for the session token. Bento is simply then running vagrant cloud plublish <acct_name>/<box_name> command. You'll get the same box names and descriptions as the bento released ones though.

@Stromweld
Copy link
Collaborator Author

Currently it's publishing all boxes publicly but I can add to it the ability to define in the builds.yml file which will be public and default to private otherwise.

@Stromweld Stromweld marked this pull request as ready for review September 15, 2023 19:00
@Stromweld Stromweld requested review from a team as code owners September 15, 2023 19:00
@Stromweld Stromweld requested a review from a team as a code owner September 15, 2023 19:00
@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Stromweld Stromweld merged commit e3da652 into main Sep 15, 2023
86 of 212 checks passed
@Stromweld Stromweld deleted the updates branch September 15, 2023 21:08
hunleyd added a commit to hunleyd/bento that referenced this pull request Sep 18, 2023
* 'main' of github.com:chef/bento:
  added vagrant upload account configuration in builds.yml (chef#1522)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants