Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default vmx_data #1512

Merged
merged 15 commits into from
Jul 6, 2023
Merged

update default vmx_data #1512

merged 15 commits into from
Jul 6, 2023

Conversation

Stromweld
Copy link
Collaborator

@Stromweld Stromweld commented Jun 23, 2023

Description

Fix arm64 machine metadata.json file generation
Update bento build command to give failure status if a machine fails to build
Update vmware default settings to fix builds
Switch to bento command for pipeline builds

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
Signed-off-by: Corey Hemminger <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Stromweld Stromweld marked this pull request as ready for review July 6, 2023 17:38
@Stromweld Stromweld requested review from a team as code owners July 6, 2023 17:38
Signed-off-by: Corey Hemminger <[email protected]>
@Stromweld Stromweld merged commit 465cb8a into main Jul 6, 2023
82 of 231 checks passed
@Stromweld Stromweld deleted the vmware_defaults branch July 6, 2023 18:00
hunleyd added a commit to hunleyd/bento that referenced this pull request Jul 8, 2023
* upstream/main:
  update default vmx_data (chef#1512)
  Add build for opensuse aarch64 (chef#1513)
  fix pipeline (chef#1508)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant