wait until runsv is reading from supervise/ok #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevendanna
commented
Aug 28, 2019
libraries/helpers.rb
Outdated
|
|
||
| # Opening the pipe for writing should block until the supervisor | ||
| # has opened it for reading. | ||
| ::File.open(path, "w").close() |
There was a problem hiding this comment.
This technically means that the user running chef-client now needs write permission on these pipes. If we are worried about that, we could rescue Errno::EACCES which is no worse than the old behavior.
srenatus
approved these changes
Aug 28, 2019
If the supervise/ok pipe already exists on disk before runsv has started, then existence check here is not enough. Since runsv opens the pipe for reading as part of its startup, we can open it for writing which will block until runsv has called open. A version of this fix has been running in one of our internal projects for some time. Signed-off-by: Steven Danna <[email protected]>
stevendanna
force-pushed
the
ssd/wait-for-pipe
branch
from
3ca4f3e
to
75a26fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the supervise/ok pipe already exists on disk before runsv has
started, then existence check here is not enough.
Since runsv opens the pipe for reading as part of its startup, we can
open it for writing which will block until runsv has called open.
A version of this fix has been running in one of our internal projects
for some time.
Check List