Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExecutionPolicy => Unrestricted for install.ps1 #550

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hh
Copy link
Contributor

@hh hh commented Oct 17, 2016

No description provided.

@hh
Copy link
Contributor Author

hh commented Oct 17, 2016

@mwrock @tyler-ball This is an obvious change, not worth a DCO (I haven't set that up yet)

@epsilon-jpage
Copy link

👍 LGTM

@mwrock
Copy link
Contributor

mwrock commented Oct 17, 2016

I'm 👎 on this since it opens a new powershell.exe process from an existing powershell session. I'd simply call Set-ExecutionPolicy -Scope Process -ExecutionPolicy Unrestricted instead.

@mwrock
Copy link
Contributor

mwrock commented Oct 17, 2016

Another thought is to add winrm-elevated to the dependencies and use an :elevated shell instead of :powershell. That could fix other things too that don't work over "normal" winrm.

@epsilon-jpage
Copy link

@mwrock In your change what was the original reasoning why the Powershell window didn't have elevated privileges before? Was it for security reasons?

@mwrock
Copy link
Contributor

mwrock commented Oct 17, 2016

@epsilon-jpage it was mainly to make the elevated shell "opt-in" since it adds new and additional functionality that could potentially break especially since winrm-elevated is fairly new.

@ajeba99
Copy link

ajeba99 commented Oct 18, 2016

Added #551

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants