Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use domhandler nodes directly #1564

Merged
merged 1 commit into from
Dec 20, 2020
Merged

Conversation

fb55
Copy link
Member

@fb55 fb55 commented Dec 15, 2020

Avoids unnecessary parser calls. Fixes #1166.

Allows us to drop lodash. Fixes #1506.

Avoids unnecessary parser calls. Fixes #1166.

Allows us to drop lodash. Fixes #1506.
"entities": "~2.1.0",
"htmlparser2": "^6.0.0",
"lodash": "^4.17.20",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@fb55 fb55 merged commit b13688f into v1.0.0 Dec 20, 2020
@fb55 fb55 deleted the refactor/domhandler-nodes branch December 20, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Replacing cloneDeepWidth with alternative Improve performance of .text()
2 participants