-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Issue #17882: Update PARAMETER_TYPE_LIST of JavadocCommentsTokenTypes to new AST format #18189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
romani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Item
| * <p>Represents multiple types in a method signature.</p> | ||
| * | ||
| * <p><b>Example:</b></p> | ||
| * <pre>{@code * (T, U)}</pre> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please extend example to be more real that uses might have in real code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update PR description with full CLI output
|
Single commit please. Please read and watch videos at Starting_Development. |
ae3f0e3 to
654a40f
Compare
Thanks @romani , i have squashed the commits and going forward, I will adhere to it strictly for all PRs |
|
Good, please update all pRs descriptions to look same at this #17883 |
205ae52 to
ca5eb6c
Compare
…TokenTypes to new AST format
ca5eb6c to
0029a71
Compare
Hi @romani , thanks for reviewing, I have squashed the commits. I see the [ci/semaphoreci/pr: Checkstyle CI pipeline on Semaphore] failed and is unrelated to my PR, d
Done. Thanks |
|
@romani Thanks for reviewing. Addressed your comments and CI all green. |
Issue #17882
Input file
Full CLI output